You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "bobbai00 (via GitHub)" <gi...@apache.org> on 2026/05/05 04:00:16 UTC

[PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

bobbai00 opened a new pull request, #4938:
URL: https://github.com/apache/texera/pull/4938

   ### What changes were proposed in this PR?
   
   Bump all Scala/Java microservices from Java 11 to Java 17 LTS.
   
   - **8 Dockerfiles under `bin/`**: build base `sbtscala/scala-sbt:eclipse-temurin-jammy-11.0.17_8_1.9.3_2.13.11` → `...-17.0.5_8_1.9.3_2.13.11` (same sbt 1.9.3 + Scala 2.13.11); runtime `eclipse-temurin:11-{jdk,jre}-jammy` → `17-{jdk,jre}-jammy`.
   - **`bin/computing-unit-{master,worker}.dockerfile`**: add `ENV JDK_JAVA_OPTIONS="--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED"` so Apache Arrow's off-heap memory module keeps working under Java 17's strong encapsulation. Other 6 service images don't exercise Arrow off-heap.
   - **`.github/workflows/build.yml` + `build-and-push-images.yml`**: `java-version: 11` → `17` (matrix entries + 5 `setup-java` steps).
   - **`AGENTS.md`**: toolchain table.
   
   ### Any related issues, documentation, discussions?
   
   Closes #4937. Refs discussion #4001 (Java 17 readiness assessment — only minor changes needed).
   
   ### How was this PR tested?
   
   Will be exercised end-to-end by CI (`build.yml` builds + tests under Java 17, `build-and-push-images.yml` produces the multi-arch images). Locally validated that the chosen sbt image tag exists on Docker Hub and that the only known runtime tweak (Arrow `--add-opens`) is in place for the workers that need it.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.7)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on code in PR #4938:
URL: https://github.com/apache/texera/pull/4938#discussion_r3186216189


##########
AGENTS.md:
##########
@@ -90,6 +90,10 @@ in [`udf.conf`](common/config/src/main/resources/udf.conf) or
 `export UDF_PYTHON_PATH="$(pwd)/../venv312/bin/python"` (env var overrides).
 Without it, `sbt` Python-integration tests fail to launch a worker.
 
+When running computing-unit master/worker outside their Docker images on
+JDK 17+, also `export JDK_JAVA_OPTIONS="--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED"`.
+Without it, [Apache Arrow Java](https://arrow.apache.org/docs/java/install.html) fails on off-heap allocation.

Review Comment:
   I fixed the link. Please check



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on code in PR #4938:
URL: https://github.com/apache/texera/pull/4938#discussion_r3212415535


##########
.jvmopts:
##########
@@ -0,0 +1,18 @@
+# JVM options for sbt's launcher script. Read by `sbt` from the build
+# root and applied to sbt's own JVM (which also runs the tests when
+# Test / fork := false, the default for this project).
+#
+# JDK 17+ --add-opens flags required by:
+#   - Apache Pekko (dispatcher / mailbox / scheduler use sun.misc.Unsafe
+#     via jdk.internal.misc, plus java.lang for virtual threads and
+#     sun.nio.ch for Aeron / NIO channels).

Review Comment:
   This part refactored, please check



##########
.jvmopts:
##########
@@ -0,0 +1,18 @@
+# JVM options for sbt's launcher script. Read by `sbt` from the build

Review Comment:
   Added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on PR #4938:
URL: https://github.com/apache/texera/pull/4938#issuecomment-4411451106

   @Yicong-Huang @aglinxinyuan can you take a look at this PR again ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on PR #4938:
URL: https://github.com/apache/texera/pull/4938#issuecomment-4377187905

   > > > Mirror:
   > > > After switching to Java 17 and running the workflows, this error occurred:
   > > > ```
   > > > [2026-05-04 22:46:53,334] [WARN] [org.ehcache.sizeof.ObjectGraphWalker] [pool-12-thread-1] - The JVM is preventing Ehcache from accessing the subgraph beneath 'private final byte[] java.lang.String.value' - cache sizes may be underestimated as a result 
   > > > java.lang.reflect.InaccessibleObjectException: Unable to make field private final byte[] java.lang.String.value accessible: module java.base does not "opens java.lang" to unnamed module @2bffa76d
   > > > 	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
   > > > 	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
   > > > 	at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
   > > > 	at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
   > > > 	at org.ehcache.sizeof.ObjectGraphWalker.getAllFields(ObjectGraphWalker.java:245)
   > > > 	at org.ehcache.sizeof.ObjectGraphWalker.getFilteredFields(ObjectGraphWalker.java:204)
   > > > 	at org.ehcache.sizeof.ObjectGraphWalker.walk(ObjectGraphWalker.java:159)
   > > > 	at org.ehcache.sizeof.SizeOf.deepSizeOf(SizeOf.java:74)
   > > > ```
   > > 
   > > 
   > > Can you try:
   > > ```
   > > export JDK_JAVA_OPTIONS="--add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED"
   > > ```
   > > 
   > > 
   > >     
   > >       
   > >     
   > > 
   > >       
   > >     
   > > 
   > >     
   > >   
   > > Ref: [ehcache/ehcache3#3008](https://github.com/ehcache/ehcache3/issues/3008)
   > 
   > Ok, it seems like the only JDK_JAVA_OPTIONS we need are "--add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED". We don't need all of them. Please update the option in the PR.
   > 
   > The ref seems incorrect by the way.
   
   Fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #4938:
URL: https://github.com/apache/texera/pull/4938#discussion_r3193412679


##########
.jvmopts:
##########
@@ -0,0 +1,18 @@
+# JVM options for sbt's launcher script. Read by `sbt` from the build

Review Comment:
   Add a header for this file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #4938:
URL: https://github.com/apache/texera/pull/4938#discussion_r3193410539


##########
.jvmopts:
##########
@@ -0,0 +1,18 @@
+# JVM options for sbt's launcher script. Read by `sbt` from the build
+# root and applied to sbt's own JVM (which also runs the tests when
+# Test / fork := false, the default for this project).
+#
+# JDK 17+ --add-opens flags required by:
+#   - Apache Pekko (dispatcher / mailbox / scheduler use sun.misc.Unsafe
+#     via jdk.internal.misc, plus java.lang for virtual threads and

Review Comment:
   do we have virtual threads?



##########
.jvmopts:
##########
@@ -0,0 +1,18 @@
+# JVM options for sbt's launcher script. Read by `sbt` from the build
+# root and applied to sbt's own JVM (which also runs the tests when
+# Test / fork := false, the default for this project).
+#
+# JDK 17+ --add-opens flags required by:
+#   - Apache Pekko (dispatcher / mailbox / scheduler use sun.misc.Unsafe
+#     via jdk.internal.misc, plus java.lang for virtual threads and
+#     sun.nio.ch for Aeron / NIO channels).

Review Comment:
   do we have Aeron / NIO channels?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #4938:
URL: https://github.com/apache/texera/pull/4938#issuecomment-4376516800

   > > * add `ENV JDK_JAVA_OPTIONS="--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED"`. This is required by Apache Arrow Java under JDK 17+ (see https://arrow.apache.org/docs/java/install.html). The other 6 service images don't exercise Arrow off-heap memory.
   > 
   > Got it. I mentioned it in the PR description and `AGENT.md`
   > 
   > The main reason I want to include it in the release branch is because Java 11 already doesn't have an LTS version. Since we use Java as the runtime image, it would be great to have an LTS base image as the runtime.
   
   Java 11 is extended to be supported till 2032. https://www.oracle.com/java/technologies/java-se-support-roadmap.html
   
   Do we HAVE to upgrade before release??


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 merged PR #4938:
URL: https://github.com/apache/texera/pull/4938


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on PR #4938:
URL: https://github.com/apache/texera/pull/4938#issuecomment-4376914818

   > Mirror:
   > 
   > After switching to Java 17 and running the workflows, this error occurred:
   > 
   > ```
   > [2026-05-04 22:46:53,334] [WARN] [org.ehcache.sizeof.ObjectGraphWalker] [pool-12-thread-1] - The JVM is preventing Ehcache from accessing the subgraph beneath 'private final byte[] java.lang.String.value' - cache sizes may be underestimated as a result 
   > java.lang.reflect.InaccessibleObjectException: Unable to make field private final byte[] java.lang.String.value accessible: module java.base does not "opens java.lang" to unnamed module @2bffa76d
   > 	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
   > 	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
   > 	at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
   > 	at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
   > 	at org.ehcache.sizeof.ObjectGraphWalker.getAllFields(ObjectGraphWalker.java:245)
   > 	at org.ehcache.sizeof.ObjectGraphWalker.getFilteredFields(ObjectGraphWalker.java:204)
   > 	at org.ehcache.sizeof.ObjectGraphWalker.walk(ObjectGraphWalker.java:159)
   > 	at org.ehcache.sizeof.SizeOf.deepSizeOf(SizeOf.java:74)
   > ```
   
   Can you try:
   ```
   export JDK_JAVA_OPTIONS="--add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED"
   ```
   
   Ref: https://github.com/ehcache/ehcache3/issues/3008


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on PR #4938:
URL: https://github.com/apache/texera/pull/4938#issuecomment-4376742778

   > Do you want to add that to the IntelliJ configuration in the .run folder so developers can also run with JDK_JAVA_OPTIONS on their local machines? Please also don't solely rely on test cases for this big change. Let's run a real workflow to manually test it.
   
   Added


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on PR #4938:
URL: https://github.com/apache/texera/pull/4938#issuecomment-4376577086

   > > > * add `ENV JDK_JAVA_OPTIONS="--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED"`. This is required by Apache Arrow Java under JDK 17+ (see https://arrow.apache.org/docs/java/install.html). The other 6 service images don't exercise Arrow off-heap memory.
   > > 
   > > 
   > > Got it. I mentioned it in the PR description and `AGENT.md`
   > > The main reason I want to include it in the release branch is because Java 11 already doesn't have an LTS version. Since we use Java as the runtime image, it would be great to have an LTS base image as the runtime.
   > 
   > Java 11 is extended to be supported till 2032. https://www.oracle.com/java/technologies/java-se-support-roadmap.html
   > 
   > Do we HAVE to upgrade before release??
   
   We don't have to. I removed the tag.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on PR #4938:
URL: https://github.com/apache/texera/pull/4938#issuecomment-4376747094

   > Do you want to add that to the IntelliJ configuration in the .run folder so developers can also run with JDK_JAVA_OPTIONS on their local machines? Please also don't solely rely on test cases for this big change. Let's run a real workflow to manually test it.
   
   During my daily development, I use Java 17 all the time and manually ran lots of workflows. So I am pretty confident with the changes.
   
   To be safe, can you try this branch and manually run some workflows to test it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #4938:
URL: https://github.com/apache/texera/pull/4938#issuecomment-4376834115

   Mirror: 
   
   Got this error message after changing to Java 17, after running the workflows:
   ```
   [2026-05-04 22:46:53,334] [WARN] [org.ehcache.sizeof.ObjectGraphWalker] [pool-12-thread-1] - The JVM is preventing Ehcache from accessing the subgraph beneath 'private final byte[] java.lang.String.value' - cache sizes may be underestimated as a result 
   java.lang.reflect.InaccessibleObjectException: Unable to make field private final byte[] java.lang.String.value accessible: module java.base does not "opens java.lang" to unnamed module @2bffa76d
   	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
   	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
   	at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
   	at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
   	at org.ehcache.sizeof.ObjectGraphWalker.getAllFields(ObjectGraphWalker.java:245)
   	at org.ehcache.sizeof.ObjectGraphWalker.getFilteredFields(ObjectGraphWalker.java:204)
   	at org.ehcache.sizeof.ObjectGraphWalker.walk(ObjectGraphWalker.java:159)
   	at org.ehcache.sizeof.SizeOf.deepSizeOf(SizeOf.java:74)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #4938:
URL: https://github.com/apache/texera/pull/4938#issuecomment-4386335775

   The amber run again hangs and drains our CI. canceled manually. please check https://github.com/apache/texera/actions/runs/25420608272/job/74575691521?pr=4938 @bobbai00 @aglinxinyuan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4938:
URL: https://github.com/apache/texera/pull/4938#issuecomment-4376448345

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/4938?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 42.18%. Comparing base ([`d50ebb0`](https://app.codecov.io/gh/apache/texera/commit/d50ebb0afa75d0790d50addd2d243db9e5f30c6b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`25ae13f`](https://app.codecov.io/gh/apache/texera/commit/25ae13f615326889b4f957cbed736c398e02d0dd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##               main    #4938   +/-   ##
   =========================================
     Coverage     42.18%   42.18%           
     Complexity     2185     2185           
   =========================================
     Files           980      980           
     Lines         36305    36305           
     Branches       3783     3783           
   =========================================
     Hits          15317    15317           
     Misses        20063    20063           
     Partials        925      925           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/4938/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/4938/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.72% <ø> (ø)` | |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/4938/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/4938?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #4938:
URL: https://github.com/apache/texera/pull/4938#issuecomment-4376522529

   > > * add `ENV JDK_JAVA_OPTIONS="--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED"`. This is required by Apache Arrow Java under JDK 17+ (see https://arrow.apache.org/docs/java/install.html). The other 6 service images don't exercise Arrow off-heap memory.
   > 
   > Got it. I mentioned it in the PR description and `AGENT.md`
   > 
   > The main reason I want to include it in the release branch is because Java 11 already doesn't have an LTS version. Since we use Java as the runtime image, it would be great to have an LTS base image as the runtime.
   
   Sorry, I missed the JDK_JAVA_OPTIONS part. Do you want to add that to IntelliJ run configurations in the .run folder such that developers can also run with JDK_JAVA_OPTIONS in their local machine?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on PR #4938:
URL: https://github.com/apache/texera/pull/4938#issuecomment-4376511662

   > * add `ENV JDK_JAVA_OPTIONS="--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED"`. This is required by Apache Arrow Java under JDK 17+ (see https://arrow.apache.org/docs/java/install.html). The other 6 service images don't exercise Arrow off-heap memory.
   
   Got it. I mentioned it in the PR description and `AGENT.md`
   
   The main reason I want to include it in the release branch is because Java 11 already doesn't have an LTS version. Since we use Java as the runtime image, it would be great to have an LTS base image as the runtime. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #4938:
URL: https://github.com/apache/texera/pull/4938#issuecomment-4377061608

   > > Mirror:
   > > After switching to Java 17 and running the workflows, this error occurred:
   > > ```
   > > [2026-05-04 22:46:53,334] [WARN] [org.ehcache.sizeof.ObjectGraphWalker] [pool-12-thread-1] - The JVM is preventing Ehcache from accessing the subgraph beneath 'private final byte[] java.lang.String.value' - cache sizes may be underestimated as a result 
   > > java.lang.reflect.InaccessibleObjectException: Unable to make field private final byte[] java.lang.String.value accessible: module java.base does not "opens java.lang" to unnamed module @2bffa76d
   > > 	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
   > > 	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
   > > 	at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
   > > 	at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
   > > 	at org.ehcache.sizeof.ObjectGraphWalker.getAllFields(ObjectGraphWalker.java:245)
   > > 	at org.ehcache.sizeof.ObjectGraphWalker.getFilteredFields(ObjectGraphWalker.java:204)
   > > 	at org.ehcache.sizeof.ObjectGraphWalker.walk(ObjectGraphWalker.java:159)
   > > 	at org.ehcache.sizeof.SizeOf.deepSizeOf(SizeOf.java:74)
   > > ```
   > 
   > Can you try:
   > 
   > ```
   > export JDK_JAVA_OPTIONS="--add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED"
   > ```
   > 
   > Ref: [ehcache/ehcache3#3008](https://github.com/ehcache/ehcache3/issues/3008)
   
   Ok, it seems like the only JDK_JAVA_OPTIONS we need are "--add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED". We don't need all of them.
   
   The ref seems incorrect by the way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on PR #4938:
URL: https://github.com/apache/texera/pull/4938#issuecomment-4376751190

   > > Java 11 is extended to be supported till 2032. https://www.oracle.com/java/technologies/java-se-support-roadmap.html
   > > Do we HAVE to upgrade before release??
   > 
   > We don't have to. I removed the tag.
   
   Many scripts are outdated currently. I prefer NOT to update them and have a separate PR to handle them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #4938:
URL: https://github.com/apache/texera/pull/4938#issuecomment-4380166975

   This CI run never finishes. I canceled it after 5 hours. https://github.com/apache/texera/actions/runs/25367504114/job/74383231727


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #4938:
URL: https://github.com/apache/texera/pull/4938#discussion_r3186154179


##########
AGENTS.md:
##########
@@ -90,6 +90,10 @@ in [`udf.conf`](common/config/src/main/resources/udf.conf) or
 `export UDF_PYTHON_PATH="$(pwd)/../venv312/bin/python"` (env var overrides).
 Without it, `sbt` Python-integration tests fail to launch a worker.
 
+When running computing-unit master/worker outside their Docker images on
+JDK 17+, also `export JDK_JAVA_OPTIONS="--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED"`.
+Without it, [Apache Arrow Java](https://arrow.apache.org/docs/java/install.html) fails on off-heap allocation.

Review Comment:
   The link does not work for me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(build): bump Scala/Java services to Java 17 LTS [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #4938:
URL: https://github.com/apache/texera/pull/4938#issuecomment-4376677845

   How about bash script in bin/? do they need to be updated for `JDK_JAVA_OPTIONS`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org