You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Brian Lillie <br...@us.ibm.com> on 2011/09/19 22:32:06 UTC
Review Request: OAuthResponseParms logger does not resolve msgKey into
appropriate message
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1960/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
If the OAuthResponseParms code calls logDetailedWarning or logDetailedInfo, it passes a message key expecting the Logging call to translate the msgKey into a message. However, no resource bundle was associated with the logger so the translation does not occur.
This addresses bug https://issues.apache.org/jira/browse/SHINDIG-1625.
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SHINDIG-1625
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java 1164090
Diff: https://reviews.apache.org/r/1960/diff
Testing
-------
Thanks,
Brian
Re: Review Request: OAuthResponseParms logger does not resolve msgKey into
appropriate message
Posted by Adam Clarke <cl...@gmail.com>.
> On 2011-09-20 08:41:49, Paul Lindner wrote:
> > thanks!
> >
Addressed in the second patch for
https://reviews.apache.org/r/1947/
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1960/#review1969
-----------------------------------------------------------
On 2011-09-19 20:32:06, Brian Lillie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1960/
> -----------------------------------------------------------
>
> (Updated 2011-09-19 20:32:06)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> If the OAuthResponseParms code calls logDetailedWarning or logDetailedInfo, it passes a message key expecting the Logging call to translate the msgKey into a message. However, no resource bundle was associated with the logger so the translation does not occur.
>
>
> This addresses bug https://issues.apache.org/jira/browse/SHINDIG-1625.
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SHINDIG-1625
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java 1164090
>
> Diff: https://reviews.apache.org/r/1960/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brian
>
>
Re: Review Request: OAuthResponseParms logger does not resolve msgKey into
appropriate message
Posted by Paul Lindner <li...@inuus.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1960/#review1969
-----------------------------------------------------------
Ship it!
thanks!
- Paul
On 2011-09-19 20:32:06, Brian Lillie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1960/
> -----------------------------------------------------------
>
> (Updated 2011-09-19 20:32:06)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> If the OAuthResponseParms code calls logDetailedWarning or logDetailedInfo, it passes a message key expecting the Logging call to translate the msgKey into a message. However, no resource bundle was associated with the logger so the translation does not occur.
>
>
> This addresses bug https://issues.apache.org/jira/browse/SHINDIG-1625.
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SHINDIG-1625
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java 1164090
>
> Diff: https://reviews.apache.org/r/1960/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brian
>
>
Re: Review Request: OAuthResponseParms logger does not resolve msgKey into
appropriate message
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1960/#review8434
-----------------------------------------------------------
Seems like this is fixed right? The JIRA is closed....could we close this review as well?
- Ryan Baxter
On June 19, 2012, 2 p.m., Brian Lillie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1960/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 2 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> If the OAuthResponseParms code calls logDetailedWarning or logDetailedInfo, it passes a message key expecting the Logging call to translate the msgKey into a message. However, no resource bundle was associated with the logger so the translation does not occur.
>
>
> This addresses bug SHINDIG-1625.
> https://issues.apache.org/jira/browse/SHINDIG-1625
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java 1164090
>
> Diff: https://reviews.apache.org/r/1960/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brian Lillie
>
>
Re: Review Request: OAuthResponseParms logger does not resolve msgKey into
appropriate message
Posted by dd...@apache.org.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1960/
-----------------------------------------------------------
(Updated June 19, 2012, 2 p.m.)
Review request for shindig.
Changes
-------
Fixing JIRA link.
Description
-------
If the OAuthResponseParms code calls logDetailedWarning or logDetailedInfo, it passes a message key expecting the Logging call to translate the msgKey into a message. However, no resource bundle was associated with the logger so the translation does not occur.
This addresses bug SHINDIG-1625.
https://issues.apache.org/jira/browse/SHINDIG-1625
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java 1164090
Diff: https://reviews.apache.org/r/1960/diff/
Testing
-------
Thanks,
Brian Lillie