You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/02/11 15:41:27 UTC
[GitHub] [zeppelin] rhajek opened a new pull request #3640: [ZEPPELIN-4602]
Added initial version of InfluxDB interpreter
rhajek opened a new pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640
### What is this PR for?
The goal is to add support for querying InfluxDB 2.x using Flux language in Zeppelin notebook.
InfluxDB 2.0 (beta) docs
https://v2.docs.influxdata.com/v2.0/
Flux language docs:
https://docs.influxdata.com/flux/
### What type of PR is it?
Feature
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-4602
### How should this be tested?
* First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
linked in docs/interpreter/influxdb.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3640: [ZEPPELIN-4602] Added
initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-602363591
@rhajek There's several failure, may be due to flaky test. Could you rerun the build ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3640:
[ZEPPELIN-4602] Added initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#discussion_r378631166
##########
File path: influxdb/README.md
##########
@@ -0,0 +1,18 @@
+InfluxDB 2.0 interpreter for Apache Zeppelin
+============================================
+
+## Description:
+
+Provide InfluxDB Interpreter for Zeppelin.
+
+## Build
+
+```
+mvn -pl zeppelin-interpreter,zeppelin-display,influxdb -DskipTests package
Review comment:
You can use `mvn -pl influxdb -am -DskipTests package`, influxdb depends on zeppelin-interpreter-shaded, so use `-am` would be easier. BTW, does influxdb interpreter depends on zeppelin-display ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3640: [ZEPPELIN-4602] Added
initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-598519154
@timhallinflux Could you paste the travis CI link ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu edited a comment on issue #3640: [ZEPPELIN-4602]
Added initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
zjffdu edited a comment on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-592788627
@rhajek This is due to code refactoring which we just rename `BaseZeppelinContext` to `ZeppelinContext`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3640:
[ZEPPELIN-4602] Added initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#discussion_r378631422
##########
File path: influxdb/pom.xml
##########
@@ -0,0 +1,87 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <artifactId>zeppelin-interpreter-parent</artifactId>
+ <groupId>org.apache.zeppelin</groupId>
+ <version>0.9.0-SNAPSHOT</version>
+ <relativePath>../zeppelin-interpreter-parent/pom.xml</relativePath>
+ </parent>
+
+ <artifactId>zeppelin-influxdb</artifactId>
+ <packaging>jar</packaging>
+ <version>0.9.0-SNAPSHOT</version>
+ <name>Zeppelin: InfluxDB interpreter</name>
+ <description>InfluxDB 2.0 timeseries database support</description>
+
+ <properties>
+ <interpreter.name>influxdb</interpreter.name>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+
+ <influxdb.client.version>1.4.0</influxdb.client.version>
+ <dependency.okhttp3.version>3.13.1</dependency.okhttp3.version>
+ <dependency.gson.version>2.8.5</dependency.gson.version>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>com.influxdb</groupId>
+ <artifactId>influxdb-client-java</artifactId>
+ <version>${influxdb.client.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.google.code.gson</groupId>
+ <artifactId>gson</artifactId>
+ <version>${dependency.gson.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.squareup.okhttp3</groupId>
+ <artifactId>mockwebserver</artifactId>
+ <version>${dependency.okhttp3.version}</version>
Review comment:
Same licence issue as above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3640: [ZEPPELIN-4602] Added
initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-601234305
Sorry, I ping the wrong id, @rhajek Could you rebase this PR and paste the travis CI link ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] rhajek commented on a change in pull request #3640:
[ZEPPELIN-4602] Added initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
rhajek commented on a change in pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#discussion_r378924877
##########
File path: influxdb/pom.xml
##########
@@ -0,0 +1,87 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <artifactId>zeppelin-interpreter-parent</artifactId>
+ <groupId>org.apache.zeppelin</groupId>
+ <version>0.9.0-SNAPSHOT</version>
+ <relativePath>../zeppelin-interpreter-parent/pom.xml</relativePath>
+ </parent>
+
+ <artifactId>zeppelin-influxdb</artifactId>
+ <packaging>jar</packaging>
+ <version>0.9.0-SNAPSHOT</version>
+ <name>Zeppelin: InfluxDB interpreter</name>
+ <description>InfluxDB 2.0 timeseries database support</description>
+
+ <properties>
+ <interpreter.name>influxdb</interpreter.name>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+
+ <influxdb.client.version>1.4.0</influxdb.client.version>
+ <dependency.okhttp3.version>3.13.1</dependency.okhttp3.version>
+ <dependency.gson.version>2.8.5</dependency.gson.version>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>com.influxdb</groupId>
+ <artifactId>influxdb-client-java</artifactId>
+ <version>${influxdb.client.version}</version>
Review comment:
I also added RxJava (Apache2 license) (used by InfluxDB client library)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] rhajek commented on issue #3640: [ZEPPELIN-4602] Added
initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
rhajek commented on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-601071911
> @rajeshkp Could you paste the travis CI link ?
Any updates ? Can I help with something ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] alexott commented on a change in pull request #3640:
[ZEPPELIN-4602] Added initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
alexott commented on a change in pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#discussion_r410890322
##########
File path: docs/interpreter/influxdb.md
##########
@@ -0,0 +1,111 @@
+---
+layout: page
+title: "InfluxDB Interpreter for Apache Zeppelin"
+description: "InfluxDB is an open-source time series database designed to handle high write and query loads."
+group: interpreter
+---
+<!--
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+{% include JB/setup %}
+
+# InfluxDB Interpreter for Apache Zeppelin
+
+<div id="toc"></div>
+
+## Overview
+[InfluxDB](https://v2.docs.influxdata.com/v2.0/) is an open-source time series database (TSDB) developed by InfluxData. It is written in Go and optimized for fast, high-availability storage and retrieval of time series data in fields such as operations monitoring, application metrics, Internet of Things sensor data, and real-time analytics.
+This interpreter allows to perform queries in [Flux Language](https://v2.docs.influxdata.com/v2.0/reference/flux/) in Zeppelin Notebook.
+
+### Notes
+* This interpreter is compatible with InfluxDB 2.0+ (v2 API, Flux language)
Review comment:
According to README, the client library is compatible with 1.8 as well: https://github.com/influxdata/influxdb-client-java#influxdb-18-api-compatibility
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] rhajek edited a comment on issue #3640: [ZEPPELIN-4602]
Added initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
rhajek edited a comment on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-595710881
Oh sorry, Instead of rebase I merged 'apache:master' into my fork 'rhajek:master'.
Now this PR should be ready for merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] rhajek commented on issue #3640: [ZEPPELIN-4602] Added
initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
rhajek commented on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-601619366
Rebased, here is the travis link: https://travis-ci.org/github/rhajek/zeppelin?utm_medium=notification&utm_source=github_status
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] rhajek commented on a change in pull request #3640:
[ZEPPELIN-4602] Added initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
rhajek commented on a change in pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#discussion_r378927819
##########
File path: influxdb/README.md
##########
@@ -0,0 +1,18 @@
+InfluxDB 2.0 interpreter for Apache Zeppelin
+============================================
+
+## Description:
+
+Provide InfluxDB Interpreter for Zeppelin.
+
+## Build
+
+```
+mvn -pl zeppelin-interpreter,zeppelin-display,influxdb -DskipTests package
Review comment:
The interpreter does not depends on zeppelin-display, I just copied it from another interpreter. It is very basic interpreter now. In future we would like to add syntax highlighting and code complete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] alexott commented on a change in pull request #3640:
[ZEPPELIN-4602] Added initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
alexott commented on a change in pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#discussion_r410890756
##########
File path: influxdb/src/main/java/org/apache/zeppelin/influxdb/InfluxDBInterpreter.java
##########
@@ -0,0 +1,203 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package org.apache.zeppelin.influxdb;
+
+import java.util.Properties;
+import java.util.StringJoiner;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.atomic.AtomicReference;
+
+import com.influxdb.LogLevel;
+import com.influxdb.client.InfluxDBClient;
+import com.influxdb.client.InfluxDBClientFactory;
+import com.influxdb.client.InfluxDBClientOptions;
+import com.influxdb.client.QueryApi;
+import org.apache.zeppelin.interpreter.AbstractInterpreter;
+import org.apache.zeppelin.interpreter.ZeppelinContext;
+import org.apache.zeppelin.interpreter.InterpreterContext;
+import org.apache.zeppelin.interpreter.InterpreterException;
+import org.apache.zeppelin.interpreter.InterpreterResult;
+
+/**
+ * <a href="https://v2.docs.influxdata.com/v2.0/">InfluxDB 2.0</a> interpreter for Zeppelin.
+ * It uses /v2/query API, query is written in Flux Language.
+ * <p>
+ * How to use: <br/>
+ * <pre>
+ * {@code
+ * %influxdb
+ * from(bucket: "my-bucket")
+ * |> range(start: -5m)
+ * |> filter(fn: (r) => r._measurement == "cpu")
+ * |> filter(fn: (r) => r._field == "usage_user")
+ * |> filter(fn: (r) => r.cpu == "cpu-total")
+ * }
+ * </pre>
+ * </p>
+ */
+public class InfluxDBInterpreter extends AbstractInterpreter {
+
+ static final String INFLUXDB_API_URL_PROPERTY = "influxdb.url";
+ static final String INFLUXDB_TOKEN_PROPERTY = "influxdb.token";
+ static final String INFLUXDB_ORG_PROPERTY = "influxdb.org";
+ private static final String INFLUXDB_LOGLEVEL_PROPERTY = "influxdb.logLevel";
+
+ private static final String TABLE_MAGIC_TAG = "%table ";
+ private static final String WHITESPACE = " ";
+ private static final String NEWLINE = "\n";
+ private static final String TAB = "\t";
+ static final String EMPTY_COLUMN_VALUE = "";
+
+ InfluxDBClient client;
+ QueryApi queryApi;
Review comment:
does it make sense to mark it as `volatile` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] rhajek edited a comment on issue #3640: [ZEPPELIN-4602]
Added initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
rhajek edited a comment on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-595710881
Oh sorry, Instead of rebase I merged 'apache:master' into my fork 'rhajek:master'.
Now my fork is synced with 'apache:master' but the git log contains also other commits :(
I reset my for and rebase again. Now this PR should be ready for merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3640:
[ZEPPELIN-4602] Added initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#discussion_r378631501
##########
File path: influxdb/pom.xml
##########
@@ -0,0 +1,87 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <artifactId>zeppelin-interpreter-parent</artifactId>
+ <groupId>org.apache.zeppelin</groupId>
+ <version>0.9.0-SNAPSHOT</version>
+ <relativePath>../zeppelin-interpreter-parent/pom.xml</relativePath>
+ </parent>
+
+ <artifactId>zeppelin-influxdb</artifactId>
+ <packaging>jar</packaging>
+ <version>0.9.0-SNAPSHOT</version>
+ <name>Zeppelin: InfluxDB interpreter</name>
+ <description>InfluxDB 2.0 timeseries database support</description>
+
+ <properties>
+ <interpreter.name>influxdb</interpreter.name>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+
+ <influxdb.client.version>1.4.0</influxdb.client.version>
+ <dependency.okhttp3.version>3.13.1</dependency.okhttp3.version>
+ <dependency.gson.version>2.8.5</dependency.gson.version>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>com.influxdb</groupId>
+ <artifactId>influxdb-client-java</artifactId>
+ <version>${influxdb.client.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.google.code.gson</groupId>
+ <artifactId>gson</artifactId>
+ <version>${dependency.gson.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.squareup.okhttp3</groupId>
+ <artifactId>mockwebserver</artifactId>
+ <version>${dependency.okhttp3.version}</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ </plugin>
+ <plugin>
+ <artifactId>maven-dependency-plugin</artifactId>
+ </plugin>
+ <plugin>
+ <artifactId>maven-resources-plugin</artifactId>
+ </plugin>
+ <plugin>
+ <artifactId>maven-shade-plugin</artifactId>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <configuration>
+ <skip>false</skip>
Review comment:
It's better to enable it. We are planning to enable it for other modules as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3640: [ZEPPELIN-4602] Added
initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-591495932
@rhajek Could you do a rebase and trigger the travis CI again ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] rhajek commented on a change in pull request #3640:
[ZEPPELIN-4602] Added initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
rhajek commented on a change in pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#discussion_r378923305
##########
File path: influxdb/pom.xml
##########
@@ -0,0 +1,87 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <artifactId>zeppelin-interpreter-parent</artifactId>
+ <groupId>org.apache.zeppelin</groupId>
+ <version>0.9.0-SNAPSHOT</version>
+ <relativePath>../zeppelin-interpreter-parent/pom.xml</relativePath>
+ </parent>
+
+ <artifactId>zeppelin-influxdb</artifactId>
+ <packaging>jar</packaging>
+ <version>0.9.0-SNAPSHOT</version>
+ <name>Zeppelin: InfluxDB interpreter</name>
+ <description>InfluxDB 2.0 timeseries database support</description>
+
+ <properties>
+ <interpreter.name>influxdb</interpreter.name>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+
+ <influxdb.client.version>1.4.0</influxdb.client.version>
+ <dependency.okhttp3.version>3.13.1</dependency.okhttp3.version>
+ <dependency.gson.version>2.8.5</dependency.gson.version>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>com.influxdb</groupId>
+ <artifactId>influxdb-client-java</artifactId>
+ <version>${influxdb.client.version}</version>
Review comment:
MIT, I added license to zeppelin-distribution/src/bin_license/LICENSE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] rhajek edited a comment on issue #3640: [ZEPPELIN-4602]
Added initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
rhajek edited a comment on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-607716980
I rebased and manually tested InfluxDB interpreter in zeppelin UI. Also `mvn -pl influxdb -am test` is passing. Travis build is also ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu edited a comment on issue #3640: [ZEPPELIN-4602]
Added initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
zjffdu edited a comment on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-598519154
@rajeshkp Could you paste the travis CI link ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3640: [ZEPPELIN-4602] Added
initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-592788627
@rhajek This is code refactoring which we just rename `BaseZeppelinContext` to `ZeppelinContext`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] rhajek commented on issue #3640: [ZEPPELIN-4602] Added
initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
rhajek commented on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-595710881
Oh sorry, Instead of rebase I merged 'apache:master' into my fork 'rhajek:master'.
Now my fork is synced with 'apache:master' but the git log contains also other commits :(
Are you able to merge this PR in current state, or should I create the new PR ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] rhajek commented on issue #3640: [ZEPPELIN-4602] Added
initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
rhajek commented on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-607716980
I rebased and manually tested InfluxDB interpreter in zeppelin UI. Also `mvn -pl influxdb -am test` is passing. Travis build is in progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3640: [ZEPPELIN-4602] Added
initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-595667676
ping @rhajek Any update ？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] rhajek commented on issue #3640: [ZEPPELIN-4602] Added
initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
rhajek commented on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-591517878
It looks like there are some breaking changes, InfluxDBInterpreter.java:[28,39] cannot find symbol symbol: class BaseZeppelinContext, I will look on that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] timhallinflux commented on issue #3640: [ZEPPELIN-4602]
Added initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
timhallinflux commented on issue #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#issuecomment-598363606
@zjffdu how does this look now? Good to go?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3640:
[ZEPPELIN-4602] Added initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#discussion_r378631341
##########
File path: influxdb/pom.xml
##########
@@ -0,0 +1,87 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <artifactId>zeppelin-interpreter-parent</artifactId>
+ <groupId>org.apache.zeppelin</groupId>
+ <version>0.9.0-SNAPSHOT</version>
+ <relativePath>../zeppelin-interpreter-parent/pom.xml</relativePath>
+ </parent>
+
+ <artifactId>zeppelin-influxdb</artifactId>
+ <packaging>jar</packaging>
+ <version>0.9.0-SNAPSHOT</version>
+ <name>Zeppelin: InfluxDB interpreter</name>
+ <description>InfluxDB 2.0 timeseries database support</description>
+
+ <properties>
+ <interpreter.name>influxdb</interpreter.name>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+
+ <influxdb.client.version>1.4.0</influxdb.client.version>
+ <dependency.okhttp3.version>3.13.1</dependency.okhttp3.version>
+ <dependency.gson.version>2.8.5</dependency.gson.version>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>com.influxdb</groupId>
+ <artifactId>influxdb-client-java</artifactId>
+ <version>${influxdb.client.version}</version>
Review comment:
What is the license of this dependency ? You need to put it in LICENCE file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] rhajek commented on a change in pull request #3640:
[ZEPPELIN-4602] Added initial version of InfluxDB interpreter
Posted by GitBox <gi...@apache.org>.
rhajek commented on a change in pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#discussion_r378924798
##########
File path: influxdb/pom.xml
##########
@@ -0,0 +1,87 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <artifactId>zeppelin-interpreter-parent</artifactId>
+ <groupId>org.apache.zeppelin</groupId>
+ <version>0.9.0-SNAPSHOT</version>
+ <relativePath>../zeppelin-interpreter-parent/pom.xml</relativePath>
+ </parent>
+
+ <artifactId>zeppelin-influxdb</artifactId>
+ <packaging>jar</packaging>
+ <version>0.9.0-SNAPSHOT</version>
+ <name>Zeppelin: InfluxDB interpreter</name>
+ <description>InfluxDB 2.0 timeseries database support</description>
+
+ <properties>
+ <interpreter.name>influxdb</interpreter.name>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+
+ <influxdb.client.version>1.4.0</influxdb.client.version>
+ <dependency.okhttp3.version>3.13.1</dependency.okhttp3.version>
+ <dependency.gson.version>2.8.5</dependency.gson.version>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>com.influxdb</groupId>
+ <artifactId>influxdb-client-java</artifactId>
+ <version>${influxdb.client.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.google.code.gson</groupId>
+ <artifactId>gson</artifactId>
+ <version>${dependency.gson.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.squareup.okhttp3</groupId>
+ <artifactId>mockwebserver</artifactId>
+ <version>${dependency.okhttp3.version}</version>
Review comment:
Apache 2, I added license to zeppelin-distribution/src/bin_license/LICENSE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services