You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Danny McCormick (Jira)" <ji...@apache.org> on 2022/06/03 15:21:00 UTC

[jira] [Comment Edited] (BEAM-421) StateTags$CombiningValueStateTag inherits equals from super class but without incorporating its state

    [ https://issues.apache.org/jira/browse/BEAM-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545998#comment-17545998 ] 

Danny McCormick edited comment on BEAM-421 at 6/3/22 3:21 PM:
--------------------------------------------------------------

This issue has been migrated to [https://github.com/apache/beam/issues/17904]


was (Author: JIRAUSER282469):
This isn't actually real, but this issue has been migrated to https://github.com/apache/beam/issues/17904

> StateTags$CombiningValueStateTag inherits equals from super class but without incorporating its state
> -----------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-421
>                 URL: https://issues.apache.org/jira/browse/BEAM-421
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Priority: P3
>              Labels: Clarified, findbugs, newbie, starter
>
> [FindBugs EQ_DOESNT_OVERRIDE_EQUALS|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L555]: Class doesn't override equals in superclass
> Applies to: [StateTags$CombiningValueStateTag|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateTags.java#L344]. CombiningValueStateTag inherits its equals implementation from its parent class, KeyedCombiningValueStateTag. CombiningValueStateTag has additional fields which are not included in the equality implementation, which may be incorrect.
> This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] and verify the build passes.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)