You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/30 18:16:40 UTC
[GitHub] [kafka] guozhangwang commented on a change in pull request #9354: KAFKA-10134 Follow-up: Set the re-join flag in heartbeat failure
guozhangwang commented on a change in pull request #9354:
URL: https://github.com/apache/kafka/pull/9354#discussion_r497709550
##########
File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -948,7 +948,7 @@ private synchronized void resetStateAndRejoin() {
synchronized void resetGenerationOnResponseError(ApiKeys api, Errors error) {
log.debug("Resetting generation after encountering {} from {} response and requesting re-join", error, api);
- resetState();
+ resetStateAndRejoin();
Review comment:
@chia7712 @dajac I think this bug is only introduced recently in this PR: https://github.com/apache/kafka/pull/8834. If your tests is executed before it then maybe there are other issues yet to be discovered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org