You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "pdolif (via GitHub)" <gi...@apache.org> on 2025/01/24 20:37:39 UTC
[PR] [fix][test] Fix flaky DelayedDeliveryTest.testEnableTopicDelayedDelivery [pulsar]
pdolif opened a new pull request, #23893:
URL: https://github.com/apache/pulsar/pull/23893
Fixes #23882
### Motivation
The test class uses a `delayedDeliveryTickTimeMillis` of 1024.
In the flaky test, a message is produced that should be delivered after 2 seconds. Then, `consumer.receive()` is called with a timeout of 1 second and it is asserted that no message is received. Because of the tick time of 1024ms, the message may already be delivered after 2s-1024ms=976ms. In this case, the test fails because a message is consumed within 1 second.
### Modifications
Configure the message to be delivered after 3 seconds (instead of 2).
This ensures that the message is delivered at the earliest after 3s-1024ms=1976ms. The `consumer.receive()` with 1 second timeout should not receive the message anymore.
After that, there is another `consumer.receive()` whose timeout was increased from 3 to 4 seconds.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/pdolif/pulsar/pull/7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix flaky DelayedDeliveryTest.testEnableTopicDelayedDelivery [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #23893:
URL: https://github.com/apache/pulsar/pull/23893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix flaky DelayedDeliveryTest.testEnableTopicDelayedDelivery [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #23893:
URL: https://github.com/apache/pulsar/pull/23893#issuecomment-2620309313
Noticed this issue in another test method in the same class after cherry-picking to branch-3.0 and running in branch-3.0: #23906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org