You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "yjhjstz (via GitHub)" <gi...@apache.org> on 2025/06/12 15:42:59 UTC
[PR] Refactor: Rename generate-greenplum-path.sh to generate-cloudberry-env [cloudberry]
yjhjstz opened a new pull request, #1156:
URL: https://github.com/apache/cloudberry/pull/1156
Refactor: Rename env script and use symlink for backward compatibility
The 'greenplum_path.sh' filename includes a third-party trademark ('Greenplum'), which is against Apache Software Foundation (ASF) policy.
To resolve this, the script is renamed to 'cloudberry_env.sh' to align with project branding and ASF guidelines.
To maintain seamless backward compatibility for existing users and automation scripts, a symbolic link is created during the installation process. The link `greenplum_path.sh` now points directly to the new `cloudberry_env.sh` file.
Fix issue: #1149
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] Requested review from [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list: [dev@cloudberry.apache.org](https://lists.apache.org/list.html?dev@cloudberry.apache.org) (subscribe: dev-subscribe@cloudberry.apache.org)
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Refactor: Rename generate-greenplum-path.sh to generate-cloudberry-env [cloudberry]
Posted by "edespino (via GitHub)" <gi...@apache.org>.
edespino commented on code in PR #1156:
URL: https://github.com/apache/cloudberry/pull/1156#discussion_r2144287323
##########
gpMgmt/Makefile:
##########
@@ -9,7 +9,8 @@ $(recurse)
generate_greenplum_path_file:
mkdir -p $(DESTDIR)$(prefix)
unset LIBPATH; \
- bin/generate-greenplum-path.sh > $(DESTDIR)$(prefix)/greenplum_path.sh
+ bin/generate-cloudberry-env.sh > $(DESTDIR)$(prefix)/cloudberry-env.sh
+ ln -s $(DESTDIR)$(prefix)/cloudberry-env.sh $(DESTDIR)$(prefix)/greenplum_path.sh
Review Comment:
This link should not be made. The entire code base (multiple repositories) needs to be updated to handle the new name. This symbolic link hides those changes.
This change is essentially removing all dependent references to greenplum_path.sh. Everything needs to reference the new file cloudberry-env.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Refactor: Rename generate-greenplum-path.sh to generate-cloudberry-env [cloudberry]
Posted by "leborchuk (via GitHub)" <gi...@apache.org>.
leborchuk commented on code in PR #1156:
URL: https://github.com/apache/cloudberry/pull/1156#discussion_r2143582100
##########
gpMgmt/Makefile:
##########
@@ -9,7 +9,8 @@ $(recurse)
generate_greenplum_path_file:
mkdir -p $(DESTDIR)$(prefix)
unset LIBPATH; \
- bin/generate-greenplum-path.sh > $(DESTDIR)$(prefix)/greenplum_path.sh
+ bin/generate-cloudberry-env.sh > $(DESTDIR)$(prefix)/cloudberry-env.sh
+ ln -s $(DESTDIR)$(prefix)/cloudberry-env.sh $(DESTDIR)$(prefix)/greenplum_path.sh
Review Comment:
Hm, I think the link should be created in the %post section of the rpm package. Because we copy the source file when installing the rpm package, and we cannot copy a symbolic link, we should create it again.
https://stackoverflow.com/questions/7521980/packaging-symlinks-via-rpmbuild
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Refactor: Rename generate-greenplum-path.sh to generate-cloudberry-env [cloudberry]
Posted by "edespino (via GitHub)" <gi...@apache.org>.
edespino commented on code in PR #1156:
URL: https://github.com/apache/cloudberry/pull/1156#discussion_r2144307296
##########
gpMgmt/Makefile:
##########
@@ -9,7 +9,8 @@ $(recurse)
generate_greenplum_path_file:
mkdir -p $(DESTDIR)$(prefix)
unset LIBPATH; \
- bin/generate-greenplum-path.sh > $(DESTDIR)$(prefix)/greenplum_path.sh
+ bin/generate-cloudberry-env.sh > $(DESTDIR)$(prefix)/cloudberry-env.sh
+ ln -s $(DESTDIR)$(prefix)/cloudberry-env.sh $(DESTDIR)$(prefix)/greenplum_path.sh
Review Comment:
@leborchuk - This symbolic link needs to be removed and not put in the RPM spec file. Simply, all references to greenplum_path.sh need to be removed. We should not introduce workarounds to allow existing processes (example: `make create-demo-cluster`) to continue to reference `greenplum_path.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Refactor: Rename generate-greenplum-path.sh to generate-cloudberry-env [cloudberry]
Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz commented on code in PR #1156:
URL: https://github.com/apache/cloudberry/pull/1156#discussion_r2145089353
##########
gpMgmt/Makefile:
##########
@@ -9,7 +9,8 @@ $(recurse)
generate_greenplum_path_file:
mkdir -p $(DESTDIR)$(prefix)
unset LIBPATH; \
- bin/generate-greenplum-path.sh > $(DESTDIR)$(prefix)/greenplum_path.sh
+ bin/generate-cloudberry-env.sh > $(DESTDIR)$(prefix)/cloudberry-env.sh
+ ln -s $(DESTDIR)$(prefix)/cloudberry-env.sh $(DESTDIR)$(prefix)/greenplum_path.sh
Review Comment:
let's discuss on https://github.com/apache/cloudberry/issues/1149, a big change!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Refactor: Rename generate-greenplum-path.sh to generate-cloudberry-env [cloudberry]
Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz commented on code in PR #1156:
URL: https://github.com/apache/cloudberry/pull/1156#discussion_r2143586472
##########
gpMgmt/Makefile:
##########
@@ -9,7 +9,8 @@ $(recurse)
generate_greenplum_path_file:
mkdir -p $(DESTDIR)$(prefix)
unset LIBPATH; \
- bin/generate-greenplum-path.sh > $(DESTDIR)$(prefix)/greenplum_path.sh
+ bin/generate-cloudberry-env.sh > $(DESTDIR)$(prefix)/cloudberry-env.sh
+ ln -s $(DESTDIR)$(prefix)/cloudberry-env.sh $(DESTDIR)$(prefix)/greenplum_path.sh
Review Comment:
But `make create-demo-cluster` need this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Refactor: Rename generate-greenplum-path.sh to generate-cloudberry-env [cloudberry]
Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz closed pull request #1156: Refactor: Rename generate-greenplum-path.sh to generate-cloudberry-env
URL: https://github.com/apache/cloudberry/pull/1156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org