You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/08 02:47:23 UTC
[GitHub] [dubbo] guohao commented on a change in pull request #8712: feature: remove TripleRpcException
guohao commented on a change in pull request #8712:
URL: https://github.com/apache/dubbo/pull/8712#discussion_r703981572
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java
##########
@@ -82,6 +88,31 @@ public static byte toDubboStatus(Code code) {
return status;
}
+ public static GrpcStatus rpcExceptionCodeToGrpc(int rpcExceptionCode) {
+ Code code;
+ switch (rpcExceptionCode) {
+ case TIMEOUT_EXCEPTION:
+ code = Code.DEADLINE_EXCEEDED;
+ break;
+ case FORBIDDEN_EXCEPTION:
+ code = Code.PERMISSION_DENIED;
+ break;
+ case LIMIT_EXCEEDED_EXCEPTION:
+ code = Code.ABORTED;
Review comment:
https://github.com/grpc/grpc/blob/master/doc/http-grpc-status-mapping.md
UNAVAILABLE will be better
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java
##########
@@ -82,6 +88,31 @@ public static byte toDubboStatus(Code code) {
return status;
}
+ public static GrpcStatus rpcExceptionCodeToGrpc(int rpcExceptionCode) {
+ Code code;
+ switch (rpcExceptionCode) {
+ case TIMEOUT_EXCEPTION:
+ code = Code.DEADLINE_EXCEEDED;
+ break;
+ case FORBIDDEN_EXCEPTION:
+ code = Code.PERMISSION_DENIED;
+ break;
+ case LIMIT_EXCEEDED_EXCEPTION:
+ code = Code.ABORTED;
+ break;
+ case TIMEOUT_TERMINATE:
+ code = Code.OUT_OF_RANGE;
+ break;
+ case METHOD_NOT_FOUND:
+ code = Code.NOT_FOUND;
+ break;
+ default:
+ code = Code.UNKNOWN;
+ break;
+ }
+ return fromCode(code);
+ }
+
Review comment:
Add `NETWORK_EXCEPTION` -> `UNAVAILABLE`
`SERIALIZATION_EXCEPTION` -> `INTERNAL`
##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java
##########
@@ -82,6 +88,31 @@ public static byte toDubboStatus(Code code) {
return status;
}
+ public static GrpcStatus rpcExceptionCodeToGrpc(int rpcExceptionCode) {
+ Code code;
+ switch (rpcExceptionCode) {
+ case TIMEOUT_EXCEPTION:
+ code = Code.DEADLINE_EXCEEDED;
+ break;
+ case FORBIDDEN_EXCEPTION:
+ code = Code.PERMISSION_DENIED;
+ break;
+ case LIMIT_EXCEEDED_EXCEPTION:
+ code = Code.ABORTED;
+ break;
+ case TIMEOUT_TERMINATE:
+ code = Code.OUT_OF_RANGE;
Review comment:
DEADLINE_EXCEEDED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org