You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/01/03 12:39:50 UTC

[GitHub] [netbeans] DevCharly opened a new pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

DevCharly opened a new pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839
 
 
   …ze buttons for multi-tabs, breadcrumb bar, search bar, etc
   
   Old:
   
   ![image](https://user-images.githubusercontent.com/5604048/71723773-345b6680-2e2e-11ea-9e54-3900bb4a8fb3.png)
   
   New:
   
   ![image](https://user-images.githubusercontent.com/5604048/71723749-21489680-2e2e-11ea-99b7-b804033af6e8.png)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] DevCharly commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

Posted by GitBox <gi...@apache.org>.
DevCharly commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839#discussion_r362888434
 
 

 ##########
 File path: platform/core.multitabs/src/org/netbeans/core/multitabs/ButtonFactory.java
 ##########
 @@ -47,7 +48,11 @@
      */
     public static JButton createDropDownButton( Controller controller ) {
         final JButton btn = new JButton( new TabListPopupAction(controller) );
-        btn.setIcon( ImageUtilities.loadImageIcon( "org/netbeans/core/multitabs/resources/down.png", true) ); //NOI18N
+        Icon icon = UIManager.getIcon("nb.multitabs.button.dropdown.icon");
+        if (icon == null) {
+            icon = ImageUtilities.loadImageIcon( "org/netbeans/core/multitabs/resources/down.png", true ); //NOI18N
 
 Review comment:
   No, not just a fallback.
   Vector icons are only used for FlatLaf.
   
   Other LaFs still use the bitmap images.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839#discussion_r362946066
 
 

 ##########
 File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatTabControlIcon.java
 ##########
 @@ -130,6 +131,21 @@ protected void paintIcon(Component c, Graphics2D g, int width, int height, doubl
         Color bgColor = new Color(0, 0, 0, 0); // Alpha zero means no background.
         Color fgColor = foreground;
         {
+            int buttonState = this.buttonState;
+            if (buttonState == -1) {
+                // get button state from component
+                if (!c.isEnabled()) {
+                    buttonState = TabControlButton.STATE_DISABLED;
 
 Review comment:
   Great!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839#discussion_r362817768
 
 

 ##########
 File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatTabControlIcon.java
 ##########
 @@ -130,6 +131,21 @@ protected void paintIcon(Component c, Graphics2D g, int width, int height, doubl
         Color bgColor = new Color(0, 0, 0, 0); // Alpha zero means no background.
         Color fgColor = foreground;
         {
+            int buttonState = this.buttonState;
+            if (buttonState == -1) {
+                // get button state from component
+                if (!c.isEnabled()) {
+                    buttonState = TabControlButton.STATE_DISABLED;
 
 Review comment:
   Have you tested that this state ends up being used? Are you sure the button does not end up trying to make its own disabled version using an ImageFilter? (In the latter case the disabled version would not look good on HiDPI screens.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] DevCharly commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

Posted by GitBox <gi...@apache.org>.
DevCharly commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839#discussion_r362891195
 
 

 ##########
 File path: platform/core.multitabs/src/org/netbeans/core/multitabs/ButtonFactory.java
 ##########
 @@ -47,7 +48,11 @@
      */
     public static JButton createDropDownButton( Controller controller ) {
         final JButton btn = new JButton( new TabListPopupAction(controller) );
-        btn.setIcon( ImageUtilities.loadImageIcon( "org/netbeans/core/multitabs/resources/down.png", true) ); //NOI18N
+        Icon icon = UIManager.getIcon("nb.multitabs.button.dropdown.icon");
+        if (icon == null) {
+            icon = ImageUtilities.loadImageIcon( "org/netbeans/core/multitabs/resources/down.png", true ); //NOI18N
 
 Review comment:
   But should be not very difficult to extend `Windows8VectorTabControlIcon` and `AquaVectorTabControlIcon` in the same way I've extended `FlatTabControlIcon`...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839#discussion_r362817402
 
 

 ##########
 File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatTabControlIcon.java
 ##########
 @@ -130,6 +131,21 @@ protected void paintIcon(Component c, Graphics2D g, int width, int height, doubl
         Color bgColor = new Color(0, 0, 0, 0); // Alpha zero means no background.
         Color fgColor = foreground;
         {
+            int buttonState = this.buttonState;
+            if (buttonState == -1) {
 
 Review comment:
   Ah. Perhaps make buttonState an Integer object and allow it to be null for this case, rather than introducing a magic number.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839#discussion_r362816996
 
 

 ##########
 File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLFCustoms.java
 ##########
 @@ -45,6 +47,21 @@
             // scale on Java 8 and Linux
             SPLIT_PANE_DIVIDER_SIZE_VERTICAL, UIScale.scale(4),
             SPLIT_PANE_DIVIDER_SIZE_HORIZONTAL, UIScale.scale(4),
+
+            // for org.openide.awt.CloseButtonFactory
+            "nb.close.tab.icon.enabled.icon", FlatTabControlIcon.get(TabControlButton.ID_CLOSE_BUTTON, TabControlButton.STATE_DEFAULT), // NOI18N
+            "nb.close.tab.icon.pressed.icon", FlatTabControlIcon.get(TabControlButton.ID_CLOSE_BUTTON, TabControlButton.STATE_PRESSED), // NOI18N
+            "nb.close.tab.icon.rollover.icon", FlatTabControlIcon.get(TabControlButton.ID_CLOSE_BUTTON, TabControlButton.STATE_ROLLOVER), // NOI18N
+            "nb.bigclose.tab.icon.enabled.icon", FlatTabControlIcon.get(TabControlButton.ID_CLOSE_BUTTON, TabControlButton.STATE_DEFAULT), // NOI18N
+            "nb.bigclose.tab.icon.pressed.icon", FlatTabControlIcon.get(TabControlButton.ID_CLOSE_BUTTON, TabControlButton.STATE_PRESSED), // NOI18N
+            "nb.bigclose.tab.icon.rollover.icon", FlatTabControlIcon.get(TabControlButton.ID_CLOSE_BUTTON, TabControlButton.STATE_ROLLOVER), // NOI18N
+
+            // for org.netbeans.core.multitabs.ButtonFactory
+            "nb.multitabs.button.dropdown.icon", FlatTabControlIcon.get(TabControlButton.ID_DROP_DOWN_BUTTON, -1), // NOI18N
 
 Review comment:
   What's the "-1" magic number here? Does it mean "not applicable?"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839#discussion_r362820887
 
 

 ##########
 File path: platform/core.multitabs/src/org/netbeans/core/multitabs/ButtonFactory.java
 ##########
 @@ -47,7 +48,11 @@
      */
     public static JButton createDropDownButton( Controller controller ) {
         final JButton btn = new JButton( new TabListPopupAction(controller) );
-        btn.setIcon( ImageUtilities.loadImageIcon( "org/netbeans/core/multitabs/resources/down.png", true) ); //NOI18N
+        Icon icon = UIManager.getIcon("nb.multitabs.button.dropdown.icon");
+        if (icon == null) {
+            icon = ImageUtilities.loadImageIcon( "org/netbeans/core/multitabs/resources/down.png", true ); //NOI18N
 
 Review comment:
   This is just a fallback, right? I assume all of these icons are vector-drawn to work with HiDPI screens?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839#discussion_r363063108
 
 

 ##########
 File path: platform/openide.awt/src/org/openide/awt/CloseButtonFactory.java
 ##########
 @@ -141,6 +141,9 @@ private static boolean isGTKLaF () {
     }
 
     private static Icon getCloseTabImage() {
+        if( null == closeTabImage ) {
+            closeTabImage = UIManager.getIcon("nb.close.tab.icon.enabled.icon"); //NOI18N
 
 Review comment:
   Sure--it's not worth any extra effort now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839#discussion_r363062376
 
 

 ##########
 File path: platform/openide.awt/src/org/openide/awt/CloseButtonFactory.java
 ##########
 @@ -141,6 +141,9 @@ private static boolean isGTKLaF () {
     }
 
     private static Icon getCloseTabImage() {
+        if( null == closeTabImage ) {
+            closeTabImage = UIManager.getIcon("nb.close.tab.icon.enabled.icon"); //NOI18N
 
 Review comment:
   While introducing new keys is an API change, the keys are not documented in ```apichange.xml```. That could be an additional task, or we could introduce a LAF guide on wiki. I would not hold this one off due to that. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] DevCharly commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

Posted by GitBox <gi...@apache.org>.
DevCharly commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839#discussion_r362858827
 
 

 ##########
 File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatTabControlIcon.java
 ##########
 @@ -130,6 +131,21 @@ protected void paintIcon(Component c, Graphics2D g, int width, int height, doubl
         Color bgColor = new Color(0, 0, 0, 0); // Alpha zero means no background.
         Color fgColor = foreground;
         {
+            int buttonState = this.buttonState;
+            if (buttonState == -1) {
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839#discussion_r362820325
 
 

 ##########
 File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLFCustoms.java
 ##########
 @@ -45,6 +47,21 @@
             // scale on Java 8 and Linux
             SPLIT_PANE_DIVIDER_SIZE_VERTICAL, UIScale.scale(4),
             SPLIT_PANE_DIVIDER_SIZE_HORIZONTAL, UIScale.scale(4),
+
+            // for org.openide.awt.CloseButtonFactory
 
 Review comment:
   I remember from https://github.com/apache/netbeans/pull/859/files that the close-button drawing code had to be duplicated between and org.openide.awt.AquaVectorCloseButton and o.n.swing.tabcontrol.plaf.AquaVectorTabControlIcon. Are both of the corresponding locations for FlatLAF updated in this PR? Do the new UIManager keys prevent the need for this duplication?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] DevCharly commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

Posted by GitBox <gi...@apache.org>.
DevCharly commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839#discussion_r362828376
 
 

 ##########
 File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatTabControlIcon.java
 ##########
 @@ -130,6 +131,21 @@ protected void paintIcon(Component c, Graphics2D g, int width, int height, doubl
         Color bgColor = new Color(0, 0, 0, 0); // Alpha zero means no background.
         Color fgColor = foreground;
         {
+            int buttonState = this.buttonState;
+            if (buttonState == -1) {
+                // get button state from component
+                if (!c.isEnabled()) {
+                    buttonState = TabControlButton.STATE_DISABLED;
 
 Review comment:
   Yes, this works. The reason is that class `FlatTabControlIcon` is not an instance of `javax.swing.ImageIcon`. So `LookAndFeel.getDisabledIcon()` returns `null` and the normal icon is used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839#discussion_r362819104
 
 

 ##########
 File path: platform/openide.awt/src/org/openide/awt/CloseButtonFactory.java
 ##########
 @@ -141,6 +141,9 @@ private static boolean isGTKLaF () {
     }
 
     private static Icon getCloseTabImage() {
+        if( null == closeTabImage ) {
+            closeTabImage = UIManager.getIcon("nb.close.tab.icon.enabled.icon"); //NOI18N
 
 Review comment:
   Adding new keys to UIManager.getDefaults() constitutes an API change; should probably update apichanges.xml. And perhaps go over the names of the new keys one more time to make sure they follow the convention of the existing keys.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi merged pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] DevCharly commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…

Posted by GitBox <gi...@apache.org>.
DevCharly commented on a change in pull request #1839: [NETBEANS-3428] FlatLaf: new close, left, right, drop-down and maximi…
URL: https://github.com/apache/netbeans/pull/1839#discussion_r362896373
 
 

 ##########
 File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLFCustoms.java
 ##########
 @@ -45,6 +47,21 @@
             // scale on Java 8 and Linux
             SPLIT_PANE_DIVIDER_SIZE_VERTICAL, UIScale.scale(4),
             SPLIT_PANE_DIVIDER_SIZE_HORIZONTAL, UIScale.scale(4),
+
+            // for org.openide.awt.CloseButtonFactory
 
 Review comment:
   Yes, I thinks so. Also FlatLaf is a single module, but Aqua/Windows LAF support is scattered to many modules.
   Anyway, there is only one close button in FlatLaf in `FlatTabControlIcon`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists