You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "RexXiong (via GitHub)" <gi...@apache.org> on 2023/02/17 06:26:23 UTC
[GitHub] [incubator-celeborn] RexXiong opened a new pull request, #1245: [CELEBORN-310] include roaringbitmap in flink plugin
RexXiong opened a new pull request, #1245:
URL: https://github.com/apache/incubator-celeborn/pull/1245
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
include roaringbitmap which is celeborn needed in plugin
### Why are the changes needed?
include roaringbitmap which is celeborn needed in plugin
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
manual
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX merged pull request #1245: [CELEBORN-310] include roaringbitmap in flink plugin
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX merged PR #1245:
URL: https://github.com/apache/incubator-celeborn/pull/1245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1245: [CELEBORN-310] include roaringbitmap in flink plugin
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #1245:
URL: https://github.com/apache/incubator-celeborn/pull/1245#discussion_r1109361304
##########
client-flink/flink-1.14-shaded/pom.xml:
##########
@@ -67,6 +71,7 @@
<include>com.google.guava:guava</include>
<include>io.netty:*</include>
<include>org.apache.commons:commons-lang3</include>
+ <include>org.roaringbitmap</include>
Review Comment:
yes it's equal to org.roaringbitmap:*，and i am going to specify its artifactId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1245: [CELEBORN-310] include roaringbitmap in flink plugin
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1245:
URL: https://github.com/apache/incubator-celeborn/pull/1245#issuecomment-1434164656
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1245?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1245](https://codecov.io/gh/apache/incubator-celeborn/pull/1245?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a0b1dd) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/3aacede5f8f2cab9bcd9ecc3fe7902ca7d204c5d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3aacede) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1245 +/- ##
============================================
+ Coverage 27.54% 27.56% +0.03%
- Complexity 808 811 +3
============================================
Files 214 214
Lines 17965 17965
Branches 1950 1950
============================================
+ Hits 4946 4951 +5
+ Misses 12691 12689 -2
+ Partials 328 325 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...oy/worker/congestcontrol/CongestionController.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS93b3JrZXIvY29uZ2VzdGNvbnRyb2wvQ29uZ2VzdGlvbkNvbnRyb2xsZXIuamF2YQ==) | `76.86% <0.00%> (-0.92%)` | :arrow_down: |
| [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `71.73% <0.00%> (+2.46%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1245: [CELEBORN-310] include roaringbitmap in flink plugin
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1245:
URL: https://github.com/apache/incubator-celeborn/pull/1245#discussion_r1109353828
##########
client-flink/flink-1.14-shaded/pom.xml:
##########
@@ -67,6 +71,7 @@
<include>com.google.guava:guava</include>
<include>io.netty:*</include>
<include>org.apache.commons:commons-lang3</include>
+ <include>org.roaringbitmap</include>
Review Comment:
does it work w/o `:*`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org