[GitHub] [hudi] trushev commented on a diff in pull request #7626: [HUDI-5516] Reduce memory footprint on workload with thousand active partitions

[GitBox <gi...@apache.org>]

trushev commented on code in PR #7626:
URL: https://github.com/apache/hudi/pull/7626#discussion_r1065293780


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java:
##########
@@ -449,6 +450,7 @@ private boolean flushBucket(DataBucket bucket) {
 
     this.eventGateway.sendEventToCoordinator(event);
     writeStatuses.addAll(writeStatus);
+    writeClient.cleanHandle(bucket.fileID);
     return true;
   }

Review Comment:
   You mean do we need to clean all handles `this.writeClient.cleanHandles()` in `flushRemaining` as we have cleaned handle here?
   
   To be honest, I'm not sure. The handle map would hold unlimited handles. Even lightweight closed handles could exceed heap size. I guess LRU cache solves this problem but not sure about benefits of such approach here
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org