You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by jb...@apache.org on 2021/01/28 18:40:34 UTC
[hadoop] branch branch-3.2 updated: [HDFS-15789] Lease renewal does
not require namesystem lock. Contributed by Daryn Sharp and Jim Brennan.
This is an automated email from the ASF dual-hosted git repository.
jbrennan pushed a commit to branch branch-3.2
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/branch-3.2 by this push:
new 8b9c883 [HDFS-15789] Lease renewal does not require namesystem lock. Contributed by Daryn Sharp and Jim Brennan.
8b9c883 is described below
commit 8b9c883ea4d8c78afaa4699a08b40be9a346993c
Author: Jim Brennan <jb...@apache.org>
AuthorDate: Thu Jan 28 18:17:15 2021 +0000
[HDFS-15789] Lease renewal does not require namesystem lock. Contributed by Daryn Sharp and Jim Brennan.
(cherry picked from commit f565476939332c2b17a0f470ac650ab55c6c0f64)
---
.../org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
index 07568ad..5abbc1b 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
@@ -3859,14 +3859,10 @@ public class FSNamesystem implements Namesystem, FSNamesystemMBean,
*/
void renewLease(String holder) throws IOException {
checkOperation(OperationCategory.WRITE);
- readLock();
- try {
- checkOperation(OperationCategory.WRITE);
- checkNameNodeSafeMode("Cannot renew lease for " + holder);
- leaseManager.renewLease(holder);
- } finally {
- readUnlock("renewLease");
- }
+ checkNameNodeSafeMode("Cannot renew lease for " + holder);
+ // fsn is not mutated so lock is not required. the leaseManger is also
+ // thread-safe.
+ leaseManager.renewLease(holder);
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org