You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Kalpak Gadre (JIRA)" <ji...@apache.org> on 2007/01/17 08:41:27 UTC

[jira] Commented: (HARMONY-1778) [classlib][swing]javax.swing.plaf.basic.BasicTabbedPaneUI.paint(null, JComponent) does not throw unspecified NPE

    [ https://issues.apache.org/jira/browse/HARMONY-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465378 ] 

Kalpak Gadre commented on HARMONY-1778:
---------------------------------------

Proposed patch.

> [classlib][swing]javax.swing.plaf.basic.BasicTabbedPaneUI.paint(null, JComponent) does not throw unspecified NPE
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1778
>                 URL: https://issues.apache.org/jira/browse/HARMONY-1778
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Nikolay Bannikov
>            Priority: Minor
>         Attachments: HARMONY-1778.patch
>
>
> RI of javax.swing.plaf.basic.BasicTabbedPaneUI.paint(null,JComponent) throws NPE while Harmony implementation of the method works silently.
> Test for reproducing:
> import junit.framework.TestCase;
> import javax.swing.JToolBar;
> import javax.swing.JTabbedPane;
> import javax.swing.plaf.basic.BasicTabbedPaneUI;
> public class Test extends TestCase {       
>       public void testBasicTabbedPaneUI_paint_Graphics_JComponent() { 
>             BasicTabbedPaneUI b = new BasicTabbedPaneUI();
>             b.installUI(new JTabbedPane());
>             try {
>                   b.paint(null, new JToolBar());
>                   fail("NPE should be thrown");
>             } catch ( NullPointerException e) {
>                   //expected 
>             }
>       }
> }
> HARMONY output:
> =============
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r450941, (Sep 28 2006), Windows/ia32/msvc 1310, release build
> http://incubator.apache.org/harmony
> .F
> Time: 1.061
> There was 1 failure:
> 1) testBasicTabbedPaneUI_paint_Graphics_JComponent(Test)junit.framework.AssertionFailedError: NPE should be thrown
>         at Test.testBasicTabbedPaneUI_paint_Graphics_JComponent(Test.java:12)
>         at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> FAILURES!!!
> Tests run: 1,  Failures: 1,  Errors: 0
> SUN output:
> ========
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> .
> Time: 0.374
> OK (1 test)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira