You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/05 15:41:01 UTC
[GitHub] [spark] cloud-fan opened a new pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
cloud-fan opened a new pull request #33655:
URL: https://github.com/apache/spark/pull/33655
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR fixes a performance regression introduced in https://github.com/apache/spark/pull/33172
Before #33172 , the target size is adaptively calculated based on the default parallelism of the spark cluster. Sometimes it's very small and #33172 sets a min partition size to fix perf issues. Sometimes the calculated size is reasonable, such as dozens of MBs.
After #33172 , we no longer calculate the target size adaptively, and by default always coalesce the partitions into 1 MB. This can cause perf regression if the adaptively calculated size is reasonable.
This PR brings back the code that adaptively calculated based on the default parallelism of the spark cluster.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
fix perf regression
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893668643
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46615/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894291692
**[Test build #142166 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142166/testReport)** for PR 33655 at commit [`eeeff3a`](https://github.com/apache/spark/commit/eeeff3ae6bb62eedeb09011cc99514d240a8b7d0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894078533
**[Test build #142144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142144/testReport)** for PR 33655 at commit [`62eff50`](https://github.com/apache/spark/commit/62eff50dc9e59caffe25b2346a14ea131072ce17).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33655:
URL: https://github.com/apache/spark/pull/33655#discussion_r683720310
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -480,6 +480,7 @@ object SQLConf {
.doc("(Deprecated since Spark 3.0)")
.version("1.6.0")
.bytesConf(ByteUnit.BYTE)
+ .checkValue(_ > 0, "advisoryPartitionSizeInBytes must be positive")
Review comment:
Could you add this check into `spark.sql.adaptive.advisoryPartitionSizeInBytes`, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894195380
**[Test build #142144 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142144/testReport)** for PR 33655 at commit [`62eff50`](https://github.com/apache/spark/commit/62eff50dc9e59caffe25b2346a14ea131072ce17).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894209491
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142144/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893572688
**[Test build #142103 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142103/testReport)** for PR 33655 at commit [`30d2824`](https://github.com/apache/spark/commit/30d2824af85e5311e0aaca2504b438d6ad3510a9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893721019
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142103/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-895075188
thanks for the review, merging to master/3.2!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894060607
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893668686
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46615/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894254029
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142131/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33655:
URL: https://github.com/apache/spark/pull/33655#discussion_r683582184
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -526,26 +526,24 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
- private val MIN_PARTITION_SIZE_KEY = "spark.sql.adaptive.coalescePartitions.minPartitionSize"
-
val COALESCE_PARTITIONS_PARALLELISM_FIRST =
buildConf("spark.sql.adaptive.coalescePartitions.parallelismFirst")
- .doc("When true, Spark ignores the target size specified by " +
+ .doc("When true, Spark does not respect the target size specified by " +
s"'${ADVISORY_PARTITION_SIZE_IN_BYTES.key}' (default 64MB) when coalescing contiguous " +
- "shuffle partitions, and only respect the minimum partition size specified by " +
- s"'$MIN_PARTITION_SIZE_KEY' (default 1MB), to maximize the parallelism. " +
- "This is to avoid performance regression when enabling adaptive query execution. " +
- "It's recommended to set this config to false and respect the target size specified by " +
- s"'${ADVISORY_PARTITION_SIZE_IN_BYTES.key}'.")
+ "shuffle partitions, but adaptively calculate the target size according to the default " +
+ "parallelism of the Spark cluster. The calculated size is usually smaller than the " +
+ "configured target size. This is to maximize the parallelism and avoid performance " +
+ "regression when enabling adaptive query execution. It's recommended to set this config " +
+ "to false and respect the configured target size.")
.version("3.2.0")
.booleanConf
.createWithDefault(true)
val COALESCE_PARTITIONS_MIN_PARTITION_SIZE =
buildConf("spark.sql.adaptive.coalescePartitions.minPartitionSize")
- .doc("The minimum size of shuffle partitions after coalescing. Its value can be at most " +
- s"20% of '${ADVISORY_PARTITION_SIZE_IN_BYTES.key}'. This is useful when the target size " +
- "is ignored during partition coalescing, which is the default case.")
+ .doc("The minimum size of shuffle partitions after coalescing. Its value can not be larger " +
+ s"than '${ADVISORY_PARTITION_SIZE_IN_BYTES.key}'. This is useful when the adaptively " +
Review comment:
The `20%` is not really necessary. Most likely no one would set it, but if anyone needs to set it, we should make it flexible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894046595
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46643/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33655:
URL: https://github.com/apache/spark/pull/33655#discussion_r683585714
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/ShufflePartitionsUtil.scala
##########
@@ -56,13 +56,9 @@ object ShufflePartitionsUtil extends Logging {
// If `minNumPartitions` is very large, it is possible that we need to use a value less than
// `advisoryTargetSize` as the target size of a coalesced task.
val totalPostShuffleInputSize = mapOutputStatistics.flatMap(_.map(_.bytesByPartitionId.sum)).sum
- // The max at here is to make sure that when we have an empty table, we only have a single
- // coalesced partition.
- // There is no particular reason that we pick 16. We just need a number to prevent
- // `maxTargetSize` from being set to 0.
- val maxTargetSize = math.max(
- math.ceil(totalPostShuffleInputSize / minNumPartitions.toDouble).toLong, 16)
- val targetSize = math.min(maxTargetSize, advisoryTargetSize)
+ val maxTargetSize = math.ceil(totalPostShuffleInputSize / minNumPartitions.toDouble).toLong
+ // It's meaningless to make target size smaller than minPartitionSize.
Review comment:
a small cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893572688
**[Test build #142103 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142103/testReport)** for PR 33655 at commit [`30d2824`](https://github.com/apache/spark/commit/30d2824af85e5311e0aaca2504b438d6ad3510a9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894291692
**[Test build #142166 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142166/testReport)** for PR 33655 at commit [`eeeff3a`](https://github.com/apache/spark/commit/eeeff3ae6bb62eedeb09011cc99514d240a8b7d0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33655:
URL: https://github.com/apache/spark/pull/33655#discussion_r683918771
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -480,6 +480,7 @@ object SQLConf {
.doc("(Deprecated since Spark 3.0)")
.version("1.6.0")
.bytesConf(ByteUnit.BYTE)
+ .checkValue(_ > 0, "advisoryPartitionSizeInBytes must be positive")
Review comment:
We can't add check in `ADVISORY_PARTITION_SIZE_IN_BYTES`, because it falls back to `SHUFFLE_TARGET_POSTSHUFFLE_INPUT_SIZE`, which is this conf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33655:
URL: https://github.com/apache/spark/pull/33655#discussion_r683612281
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -526,28 +527,26 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
- private val MIN_PARTITION_SIZE_KEY = "spark.sql.adaptive.coalescePartitions.minPartitionSize"
-
val COALESCE_PARTITIONS_PARALLELISM_FIRST =
buildConf("spark.sql.adaptive.coalescePartitions.parallelismFirst")
- .doc("When true, Spark ignores the target size specified by " +
+ .doc("When true, Spark does not respect the target size specified by " +
s"'${ADVISORY_PARTITION_SIZE_IN_BYTES.key}' (default 64MB) when coalescing contiguous " +
- "shuffle partitions, and only respect the minimum partition size specified by " +
- s"'$MIN_PARTITION_SIZE_KEY' (default 1MB), to maximize the parallelism. " +
- "This is to avoid performance regression when enabling adaptive query execution. " +
- "It's recommended to set this config to false and respect the target size specified by " +
- s"'${ADVISORY_PARTITION_SIZE_IN_BYTES.key}'.")
+ "shuffle partitions, but adaptively calculate the target size according to the default " +
+ "parallelism of the Spark cluster. The calculated size is usually smaller than the " +
+ "configured target size. This is to maximize the parallelism and avoid performance " +
+ "regression when enabling adaptive query execution. It's recommended to set this config " +
+ "to false and respect the configured target size.")
.version("3.2.0")
.booleanConf
.createWithDefault(true)
val COALESCE_PARTITIONS_MIN_PARTITION_SIZE =
buildConf("spark.sql.adaptive.coalescePartitions.minPartitionSize")
- .doc("The minimum size of shuffle partitions after coalescing. Its value can be at most " +
- s"20% of '${ADVISORY_PARTITION_SIZE_IN_BYTES.key}'. This is useful when the target size " +
Review comment:
The limitation is not really necessary. Most likely no one would set it, but if anyone needs to set it, we should make it flexible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894078533
**[Test build #142144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142144/testReport)** for PR 33655 at commit [`62eff50`](https://github.com/apache/spark/commit/62eff50dc9e59caffe25b2346a14ea131072ce17).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894473107
**[Test build #142166 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142166/testReport)** for PR 33655 at commit [`eeeff3a`](https://github.com/apache/spark/commit/eeeff3ae6bb62eedeb09011cc99514d240a8b7d0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893668686
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46615/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894457262
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46678/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893613186
**[Test build #142105 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142105/testReport)** for PR 33655 at commit [`e3d477b`](https://github.com/apache/spark/commit/e3d477bb3a75ccccd08db419baaf9a2e6c8c4a01).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894254029
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142131/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893788729
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142105/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894000661
**[Test build #142131 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142131/testReport)** for PR 33655 at commit [`62eff50`](https://github.com/apache/spark/commit/62eff50dc9e59caffe25b2346a14ea131072ce17).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894113402
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46656/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894113402
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46656/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33655:
URL: https://github.com/apache/spark/pull/33655#discussion_r684347752
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -480,6 +480,7 @@ object SQLConf {
.doc("(Deprecated since Spark 3.0)")
.version("1.6.0")
.bytesConf(ByteUnit.BYTE)
+ .checkValue(_ > 0, "advisoryPartitionSizeInBytes must be positive")
Review comment:
@cloud-fan . If we set negative values to `advisoryPartitionSizeInBytes` explicitly, it will not fallback to here. If we want to say, `advisoryPartitionSizeInBytes must be positive`, we should check both places, shouldn't we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894457262
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46678/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893613186
**[Test build #142105 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142105/testReport)** for PR 33655 at commit [`e3d477b`](https://github.com/apache/spark/commit/e3d477bb3a75ccccd08db419baaf9a2e6c8c4a01).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893972860
@dongjoon-hyun It's hard to write tests for performance regression, and this one relies on default parallelism which is even harder to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893665555
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46617/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894286994
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893788729
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142105/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893721019
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142103/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893561236
cc @yaooqinn @maryannxue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894417596
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46678/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894038490
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46643/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894046595
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46643/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #33655:
URL: https://github.com/apache/spark/pull/33655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894487511
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142166/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894209491
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142144/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894020840
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46643/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893720355
**[Test build #142103 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142103/testReport)** for PR 33655 at commit [`30d2824`](https://github.com/apache/spark/commit/30d2824af85e5311e0aaca2504b438d6ad3510a9).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893664342
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46617/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894450427
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46678/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893786491
**[Test build #142105 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142105/testReport)** for PR 33655 at commit [`e3d477b`](https://github.com/apache/spark/commit/e3d477bb3a75ccccd08db419baaf9a2e6c8c4a01).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893619375
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46615/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-893665555
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46617/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33655: [SPARK-36430][SQL] Adaptively calculate the target size when coalescing shuffle partitions in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33655:
URL: https://github.com/apache/spark/pull/33655#issuecomment-894487511
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142166/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org