You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/20 12:08:45 UTC

[GitHub] [arrow] lidavidm commented on a change in pull request #10201: ARROW-11776: [Java][Dataset] Support writing to files within dataset scanner via JNI

lidavidm commented on a change in pull request #10201:
URL: https://github.com/apache/arrow/pull/10201#discussion_r636040540



##########
File path: cpp/src/jni/dataset/jni_wrapper.cc
##########
@@ -166,6 +156,126 @@ class DisposableScannerAdaptor {
   }
 };
 
+/// \brief Simple scan task implementation that is constructed directly
+/// from a record batch iterator (and its corresponding fragment).
+class SimpleIteratorTask : public arrow::dataset::ScanTask {

Review comment:
       ScanTask is going away. However, from a quick glance, what we want here is a Scanner from a RecordBatchIterator. Use the existing Scanner::FromRecordBatchReader:
   
   https://github.com/apache/arrow/blob/8b0e04961790003abb32ef03e19a4604060e88ec/cpp/src/arrow/dataset/scanner.h#L323-L329




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org