[jira] [Commented] (ARTEMIS-1011) Slow consumer detection - producer msg/s rate for queue should take into account messages which are already in queue

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853179#comment-16853179 ] 

ASF subversion and git services commented on ARTEMIS-1011:
----------------------------------------------------------

Commit ef2ec7b56ea7dcae33c17dcadab05411ad8be282 in activemq-artemis's branch refs/heads/master from brusdev
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=ef2ec7b ]

ARTEMIS-1011 Slow consumer detection after bursts

Fix slow consumer detection after a burst, taking into account messages
which are already in queue at the start of queueRateCheckTime period.


> Slow consumer detection - producer msg/s rate for queue should take into account messages which are already in queue
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1011
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1011
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 1.5.3
>            Reporter: Miroslav Novak
>            Assignee: Justin Bertram
>            Priority: Major
>             Fix For: unscheduled
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> There is still a problem how producer msg/s rate is calculated in {{QueueImpl.getRate()}} for slow consumer detection. It calculates only messages added during the last slow consumer check period. As this is used to figure out, in which msg/s rate the queue could serve the consumer then it should also take into account messages which are already in queue at the start of queueRateCheckTime period. 
> Current implementation is problem for cases when messages are sent to queue in bursts, for example producer sends 1000s messages in a few seconds and then stops and will do that again in 1 hour. QueueImpl.getRate() method returns 0 msg/s for slow consumer check period set to for example 5 min and slow consumer detection will be skipped. 
> I tried to fix it by following change to QueueImpl.getRate() method and seems to be ok, wdyt?
> {code}
>    private final AtomicLong messageCountSnapshot = new AtomicLong(0);
>    public float getRate() {
>       long locaMessageAdded = getMessagesAdded();
>       float timeSlice = ((System.currentTimeMillis() - queueRateCheckTime.getAndSet(System.currentTimeMillis())) / 1000.0f);
>       if (timeSlice == 0) {
>          messagesAddedSnapshot.getAndSet(locaMessageAdded);
>          return 0.0f;
>       }
>       return BigDecimal.valueOf(((locaMessageAdded - messagesAddedSnapshot.getAndSet(locaMessageAdded)) + messageCountSnapshot.getAndSet(getMessageCount())) / timeSlice).setScale(2, BigDecimal.ROUND_UP).floatValue();
>    }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)