You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Sperling <st...@elego.de> on 2008/03/23 13:27:54 UTC
Re: svn commit: propchange - r30004 - svn:log
On Sat, Mar 22, 2008 at 04:13:55PM -0700, kfogel@tigris.org wrote:
> Author: kfogel
> Revision: 30004
> Property Name: svn:log
> Action: modified
>
> Property diff:
> --- old property value
> +++ new property value
> @@ -11,8 +11,8 @@ first address happens to be IPv6 loopbac
> configured to reject any IPv6 packets.
> See http://svn.haxx.se/dev/archive-2008-03/0605.shtml
>
> -Patch by: Joe Orton <jo...@light.plus.com>
> -(Updated for current trunk by me. Got his email from the COMMITTERS file).
> +Patch by: joe
> +(Updated for current trunk by me.)
>
So I guess that means we always list full committers by only
their tigris.org nick?
--
Stefan Sperling <st...@elego.de> Software Developer
elego Software Solutions GmbH HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12 Tel: +49 30 23 45 86 96
13355 Berlin Fax: +49 30 23 45 86 95
http://www.elego.de Geschaeftsfuehrer: Olaf Wagner
Re: svn commit: propchange - r30004 - svn:log
Posted by Karl Fogel <kf...@red-bean.com>.
Stefan Sperling <st...@elego.de> writes:
> --- www/hacking.html (revision 30003)
> +++ www/hacking.html (working copy)
> @@ -1642,8 +1642,8 @@ author:</p>
> <p>If multiple individuals wrote the patch, list them each on a
> separate line — making sure to start each continuation
> line with whitespace. Non-committers should be listed by name, if
> -known, and e-mail. Committers may be listed similarly, or by their
> -canonical usernames from <a
> +known, and e-mail. Full and partial committers may be listed similarly,
> +but preferably by their canonical usernames from <a
> href="http://svn.collab.net/repos/svn/trunk/COMMITTERS"
> >COMMITTERS</a> (the leftmost column in that file). Additionally,
> "me" is an acceptable shorthand for the person actually committing the
+1 here.
> No way, I'd have to learn emacs first -- learning the other well-known
> editor in existence was enough of a time investment for me already :)
There are other editors?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: propchange - r30004 - svn:log
Posted by Stefan Sperling <st...@elego.de>.
On Sun, Mar 23, 2008 at 01:15:50PM -0400, Karl Fogel wrote:
> Stefan Sperling <st...@elego.de> writes:
> > So I guess that means we always list full committers by only
> > their tigris.org nick?
>
> Typically, yes -- not just global committers, but any committer, area
> committers too. It's not a big deal, though. The reasons I think
> committer nick is better are:
OK.
> Hmmm, maybe http://subversion.tigris.org/hacking.html#crediting should
> mention all this?
It already mentions it, but could be more explicit about the
preferred way of listing committers:
Index: www/hacking.html
===================================================================
--- www/hacking.html (revision 30003)
+++ www/hacking.html (working copy)
@@ -1642,8 +1642,8 @@ author:</p>
<p>If multiple individuals wrote the patch, list them each on a
separate line — making sure to start each continuation
line with whitespace. Non-committers should be listed by name, if
-known, and e-mail. Committers may be listed similarly, or by their
-canonical usernames from <a
+known, and e-mail. Full and partial committers may be listed similarly,
+but preferably by their canonical usernames from <a
href="http://svn.collab.net/repos/svn/trunk/COMMITTERS"
>COMMITTERS</a> (the leftmost column in that file). Additionally,
"me" is an acceptable shorthand for the person actually committing the
> (Btw, I just used 'M-x svn-hacking-url' from tools/dev/svn-dev.el to
> enter the above URL, and it saved me a lot of time. Try it out,
> everyone!)
No way, I'd have to learn emacs first -- learning the other well-known
editor in existence was enough of a time investment for me already :)
--
Stefan Sperling <st...@elego.de> Software Developer
elego Software Solutions GmbH HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12 Tel: +49 30 23 45 86 96
13355 Berlin Fax: +49 30 23 45 86 95
http://www.elego.de Geschaeftsfuehrer: Olaf Wagner
Re: svn commit: propchange - r30004 - svn:log
Posted by Karl Fogel <kf...@red-bean.com>.
Stefan Sperling <st...@elego.de> writes:
>> Property diff:
>> --- old property value
>> +++ new property value
>> @@ -11,8 +11,8 @@ first address happens to be IPv6 loopbac
>> configured to reject any IPv6 packets.
>> See http://svn.haxx.se/dev/archive-2008-03/0605.shtml
>>
>> -Patch by: Joe Orton <jo...@light.plus.com>
>> -(Updated for current trunk by me. Got his email from the COMMITTERS file).
>> +Patch by: joe
>> +(Updated for current trunk by me.)
>
> So I guess that means we always list full committers by only
> their tigris.org nick?
Typically, yes -- not just global committers, but any committer, area
committers too. It's not a big deal, though. The reasons I think
committer nick is better are:
- Adds one level of indirection, so if they change their email
address in COMMITTERS, all the log messages are still up-to-date.
- Makes identity unification easier. As you know, contribulyze.py
tries to fold together all the variants of the same person
(sometimes just the email address appears, sometimes just the name,
sometiems both). But this process is heuristic, not perfectly
reliable. By using nick whenever available, we increase the
reliability for those people, at least.
Hmmm, maybe http://subversion.tigris.org/hacking.html#crediting should
mention all this?
(Btw, I just used 'M-x svn-hacking-url' from tools/dev/svn-dev.el to
enter the above URL, and it saved me a lot of time. Try it out,
everyone!)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org