You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Michele Milesi (Code Review)" <ge...@cloudera.org> on 2019/11/18 21:08:13 UTC

[kudu-CR] [Java] Fixed Type.getTypeForName method.

Hello Kudu Jenkins, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14736

to look at the new patch set (#2).

Change subject: [Java] Fixed Type.getTypeForName method.
......................................................................

[Java] Fixed Type.getTypeForName method.

Original version uses only name() method to check Type name.
Output from name() (inerrithed from Enum) method was different from output from Type.getName() method (ie INT32 vs int32), so the check fails.

Now the method uses both getName() and name() to check Type name.

Change-Id: Ibd0f4f614125d630d128c36fce05f22e19c60100
---
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
A java/kudu-client/src/test/java/org/apache/kudu/TestType.java
2 files changed, 53 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/14736/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibd0f4f614125d630d128c36fce05f22e19c60100
Gerrit-Change-Number: 14736
Gerrit-PatchSet: 2
Gerrit-Owner: Michele Milesi <mi...@icteam.it>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)