[GitHub] [dolphinscheduler] Radeity commented on a diff in pull request #14023: [fix-#14022]process instance can not stop

["Radeity (via GitHub)" <gi...@apache.org>]

Radeity commented on code in PR #14023:
URL: https://github.com/apache/dolphinscheduler/pull/14023#discussion_r1178424951


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/StateWheelExecuteThread.java:
##########
@@ -370,6 +370,11 @@ private void checkTask4State() {
                     taskInstanceStateCheckList.remove(taskInstanceKey);
                     continue;
                 }
+                ProcessInstance processInstance = workflowExecuteThread.getProcessInstance();
+                if (processInstance.getState().isReadyStop()) {
+                    taskInstanceStateCheckList.remove(taskInstanceKey);

Review Comment:
   Should we add `addProcessStopEvent(processInstance)` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org