You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Andrii Biletskyi <an...@stealth.ly> on 2014/12/03 12:46:23 UTC

Review Request 28643: Patch for KAFKA-1802

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28643/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1802
    https://issues.apache.org/jira/browse/KAFKA-1802


Repository: kafka


Description
-------

Patch for KAFKA-1802 [on top of patch for KAFKA-1772]


Diffs
-----

  clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java 109fc965e09b2ed186a073351bd037ac8af20a4c 
  clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java 7517b879866fc5dad5f8d8ad30636da8bbe7784a 
  clients/src/main/java/org/apache/kafka/common/requests/AdminRequest.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/requests/AdminResponse.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/requests/ClusterMetadataRequest.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/requests/ClusterMetadataResponse.java PRE-CREATION 
  clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java df37fc6d8f0db0b8192a948426af603be3444da4 
  core/src/main/scala/kafka/api/AdminRequest.scala PRE-CREATION 
  core/src/main/scala/kafka/api/AdminResponse.scala PRE-CREATION 
  core/src/main/scala/kafka/api/ClusterMetadataRequest.scala PRE-CREATION 
  core/src/main/scala/kafka/api/ClusterMetadataResponse.scala PRE-CREATION 
  core/src/main/scala/kafka/api/RequestKeys.scala c24c0345feedc7b9e2e9f40af11bfa1b8d328c43 
  core/src/main/scala/kafka/api/admin/request/args/ParseException.scala PRE-CREATION 
  core/src/main/scala/kafka/api/admin/request/args/TopicCommandArguments.scala PRE-CREATION 
  core/src/main/scala/kafka/common/AdminRequestFailedException.scala PRE-CREATION 
  core/src/main/scala/kafka/common/ErrorMapping.scala eedc2f5f21dd8755fba891998456351622e17047 
  core/src/main/scala/kafka/server/KafkaApis.scala 2a1c0326b6e6966d8b8254bd6a1cb83ad98a3b80 
  core/src/main/scala/kafka/server/MetadataCache.scala bf81a1ab88c14be8697b441eedbeb28fa0112643 
  core/src/test/scala/unit/kafka/api/AdminRequestTest.scala PRE-CREATION 
  core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala cd16ced5465d098be7a60498326b2a98c248f343 

Diff: https://reviews.apache.org/r/28643/diff/


Testing
-------


Thanks,

Andrii Biletskyi

Re: Review Request 28643: Patch for KAFKA-1802

Posted by Andrii Biletskyi <an...@stealth.ly>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28643/
-----------------------------------------------------------

(Updated Dec. 8, 2014, 10:56 a.m.)


Review request for kafka.


Bugs: KAFKA-1802
    https://issues.apache.org/jira/browse/KAFKA-1802


Repository: kafka


Description (updated)
-------

KAFKA-1802 -  Add a new type of request for the discovery of the controller


KAFKA-1802 -  UpdateMetadataRequest is not sent on startup, so brokers do not cache cluster info


Diffs (updated)
-----

  clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java 109fc965e09b2ed186a073351bd037ac8af20a4c 
  clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java 7517b879866fc5dad5f8d8ad30636da8bbe7784a 
  clients/src/main/java/org/apache/kafka/common/requests/AdminRequest.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/requests/AdminResponse.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/requests/ClusterMetadataRequest.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/requests/ClusterMetadataResponse.java PRE-CREATION 
  clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java df37fc6d8f0db0b8192a948426af603be3444da4 
  core/src/main/scala/kafka/api/AdminRequest.scala PRE-CREATION 
  core/src/main/scala/kafka/api/AdminResponse.scala PRE-CREATION 
  core/src/main/scala/kafka/api/ClusterMetadataRequest.scala PRE-CREATION 
  core/src/main/scala/kafka/api/ClusterMetadataResponse.scala PRE-CREATION 
  core/src/main/scala/kafka/api/RequestKeys.scala c24c0345feedc7b9e2e9f40af11bfa1b8d328c43 
  core/src/main/scala/kafka/api/admin/request/args/ParseException.scala PRE-CREATION 
  core/src/main/scala/kafka/api/admin/request/args/TopicCommandArguments.scala PRE-CREATION 
  core/src/main/scala/kafka/common/AdminRequestFailedException.scala PRE-CREATION 
  core/src/main/scala/kafka/common/ErrorMapping.scala eedc2f5f21dd8755fba891998456351622e17047 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala eb492f00449744bc8d63f55b393e2a1659d38454 
  core/src/main/scala/kafka/controller/KafkaController.scala 66df6d2fbdbdd556da6bea0df84f93e0472c8fbf 
  core/src/main/scala/kafka/server/KafkaApis.scala 2a1c0326b6e6966d8b8254bd6a1cb83ad98a3b80 
  core/src/main/scala/kafka/server/MetadataCache.scala bf81a1ab88c14be8697b441eedbeb28fa0112643 
  core/src/test/scala/unit/kafka/api/AdminRequestTest.scala PRE-CREATION 
  core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala cd16ced5465d098be7a60498326b2a98c248f343 

Diff: https://reviews.apache.org/r/28643/diff/


Testing
-------


Thanks,

Andrii Biletskyi