[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2326: LUCENE-9747: deal with NPE when package-info.java missing in the error messaging

[GitBox <gi...@apache.org>]

muse-dev[bot] commented on a change in pull request #2326:
URL: https://github.com/apache/lucene-solr/pull/2326#discussion_r572446391



##########
File path: dev-tools/missing-doclet/src/main/java/org/apache/lucene/missingdoclet/MissingDoclet.java
##########
@@ -430,6 +430,11 @@ private void error(Element element, String message) {
     fullMessage.append(element.getKind().toString().toLowerCase(Locale.ROOT));
     fullMessage.append("): ");
     fullMessage.append(message);
-    reporter.print(Diagnostic.Kind.ERROR, element, fullMessage.toString());
+    if (((element.getKind() == ElementKind.PACKAGE) && (fullMessage.toString().contains("javadocs are missing")))){

Review comment:
       *UnnecessaryParentheses:*  Unnecessary use of grouping parentheses




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org