You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2009/12/17 04:20:56 UTC

DO NOT REPLY [Bug 48399] New: Lock fields should be final

https://issues.apache.org/bugzilla/show_bug.cgi?id=48399

           Summary: Lock fields should be final
           Product: Tomcat 7
           Version: trunk
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: sebb@apache.org


Created an attachment (id=24715)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24715)
Patch lock field that should be final

A field that is used as a lock should be final. 

org.apache.catalina.ha.session.DeltaSession.diffLock

is protected and mutable.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48399] Lock fields should be final

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48399

--- Comment #1 from Sebb <se...@apache.org> 2009-12-16 19:36:16 UTC ---
Created an attachment (id=24716)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24716)
Patch fields that should be final

Two more locks that need protection.

In the case of MultiLockFairBlockingQueue, the array was final, but needs to be
private to prevent accidental or malicious changes.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48399] Lock fields should be final

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48399

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Mark Thomas <ma...@apache.org> 2009-12-19 19:46:09 GMT ---
Thanks for the patches. These have been applied to trunk.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org