Branch/Java questions re: contributing code

[Ryan Cutter <ry...@gmail.com>]

1. Should we be using Java 6 or 7?  The docs say 1.6 (
http://wiki.apache.org/solr/HowToContribute) but running 'ant test' on
trunk/ yields:

..../lucene/common-build.xml:328: Minimum supported Java version is 1.7.

I don't get that error with branch_4x/ which leads to my next question.

2. Should work toward 4.X be done on trunk/ or branch_4x/?  It sounds like
patches should be based on trunk then it gets ported as necessary.

Thanks! Ryan

RE: Branch/Java questions re: contributing code

[Markus Jelsma <ma...@openindex.io>]

Trunk (5.x)  requires Java 1.7, 4.x still works with 1.6. Check the CHANGES.txt, you'll see it near the top.

 
 
-----Original message-----
> From:Ryan Cutter <ry...@gmail.com>
> Sent: Monday 6th January 2014 16:27
> To: solr-user@lucene.apache.org
> Subject: Branch/Java questions re: contributing code
> 
> 1. Should we be using Java 6 or 7?  The docs say 1.6 (
> http://wiki.apache.org/solr/HowToContribute) but running 'ant test' on
> trunk/ yields:
> 
> ..../lucene/common-build.xml:328: Minimum supported Java version is 1.7.
> 
> I don't get that error with branch_4x/ which leads to my next question.
> 
> 2. Should work toward 4.X be done on trunk/ or branch_4x/?  It sounds like
> patches should be based on trunk then it gets ported as necessary.
> 
> Thanks! Ryan
> 

Re: Branch/Java questions re: contributing code

[Ryan Cutter <ry...@gmail.com>]

Thanks, everything worked fine after these pointers and I was able to
generate a patch properly.

Cheers, Ryan


On Mon, Jan 6, 2014 at 7:31 AM, Shalin Shekhar Mangar <
shalinmangar@gmail.com> wrote:

> On Mon, Jan 6, 2014 at 8:54 PM, Ryan Cutter <ry...@gmail.com> wrote:
> > 1. Should we be using Java 6 or 7?  The docs say 1.6 (
> > http://wiki.apache.org/solr/HowToContribute) but running 'ant test' on
> > trunk/ yields:
> >
> > ..../lucene/common-build.xml:328: Minimum supported Java version is 1.7.
> >
> > I don't get that error with branch_4x/ which leads to my next question.
>
> branch_4x is on Java 6 and trunk is on Java 7.
>
> >
> > 2. Should work toward 4.X be done on trunk/ or branch_4x/?  It sounds
> like
> > patches should be based on trunk then it gets ported as necessary.
> >
> > Thanks! Ryan
>
> Yeah, you are right. Features are committed to trunk first and
> backported to branch_4x
>
> --
> Regards,
> Shalin Shekhar Mangar.
>

Re: Branch/Java questions re: contributing code

[Shalin Shekhar Mangar <sh...@gmail.com>]

On Mon, Jan 6, 2014 at 8:54 PM, Ryan Cutter <ry...@gmail.com> wrote:
> 1. Should we be using Java 6 or 7?  The docs say 1.6 (
> http://wiki.apache.org/solr/HowToContribute) but running 'ant test' on
> trunk/ yields:
>
> ..../lucene/common-build.xml:328: Minimum supported Java version is 1.7.
>
> I don't get that error with branch_4x/ which leads to my next question.

branch_4x is on Java 6 and trunk is on Java 7.

>
> 2. Should work toward 4.X be done on trunk/ or branch_4x/?  It sounds like
> patches should be based on trunk then it gets ported as necessary.
>
> Thanks! Ryan

Yeah, you are right. Features are committed to trunk first and
backported to branch_4x

-- 
Regards,
Shalin Shekhar Mangar.