You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2017/05/24 17:30:06 UTC
Review Request 59533: Test Sandbox fix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59533/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
Repository: atlas
Description
-------
Due to race condition, a couple of test still end up using the same directory for DB/index storage.
This change checks for the existence of the folder and generates the name again in case of any discrepancy.
Diffs
-----
graphdb/common/src/test/java/org/apache/atlas/graph/GraphSandboxUtil.java 44ad4fc0
Diff: https://reviews.apache.org/r/59533/diff/1/
Testing
-------
mvn clean package executes successfully
mvn clean install executes successfully with one consitent failure related to notification processing.
Thanks,
Apoorv Naik
Re: Review Request 59533: Test Sandbox fix
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59533/#review176138
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On May 25, 2017, 2:07 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59533/
> -----------------------------------------------------------
>
> (Updated May 25, 2017, 2:07 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Due to race condition, a couple of test still end up using the same directory for DB/index storage.
>
> This change checks for the existence of the folder and generates the name again in case of any discrepancy.
>
>
> Diffs
> -----
>
> graphdb/common/src/test/java/org/apache/atlas/graph/GraphSandboxUtil.java 44ad4fc0
> repository/src/test/java/org/apache/atlas/DBSandboxer.java cc8e0e27
>
>
> Diff: https://reviews.apache.org/r/59533/diff/2/
>
>
> Testing
> -------
>
> mvn clean package executes successfully
> mvn clean install executes successfully with one consitent failure related to notification processing.
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 59533: Test Sandbox fix
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59533/
-----------------------------------------------------------
(Updated May 25, 2017, 9:07 p.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
Changes
-------
Added Sandbox naming capability, defaults to UUID.
Repository: atlas
Description
-------
Due to race condition, a couple of test still end up using the same directory for DB/index storage.
This change checks for the existence of the folder and generates the name again in case of any discrepancy.
Diffs (updated)
-----
graphdb/common/src/test/java/org/apache/atlas/graph/GraphSandboxUtil.java 44ad4fc0
repository/src/test/java/org/apache/atlas/DBSandboxer.java cc8e0e27
Diff: https://reviews.apache.org/r/59533/diff/2/
Changes: https://reviews.apache.org/r/59533/diff/1-2/
Testing
-------
mvn clean package executes successfully
mvn clean install executes successfully with one consitent failure related to notification processing.
Thanks,
Apoorv Naik
Re: Review Request 59533: Test Sandbox fix
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59533/#review175961
-----------------------------------------------------------
graphdb/common/src/test/java/org/apache/atlas/graph/GraphSandboxUtil.java
Line 40 (original), 41 (patched)
<https://reviews.apache.org/r/59533/#comment249311>
can you consider appending UUID with storage/index directory. It should be unique across forked process.
- Sarath Subramanian
On May 24, 2017, 10:30 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59533/
> -----------------------------------------------------------
>
> (Updated May 24, 2017, 10:30 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Due to race condition, a couple of test still end up using the same directory for DB/index storage.
>
> This change checks for the existence of the folder and generates the name again in case of any discrepancy.
>
>
> Diffs
> -----
>
> graphdb/common/src/test/java/org/apache/atlas/graph/GraphSandboxUtil.java 44ad4fc0
>
>
> Diff: https://reviews.apache.org/r/59533/diff/1/
>
>
> Testing
> -------
>
> mvn clean package executes successfully
> mvn clean install executes successfully with one consitent failure related to notification processing.
>
>
> Thanks,
>
> Apoorv Naik
>
>