You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Alik Eliashberg (JIRA)" <de...@velocity.apache.org> on 2007/08/02 21:27:52 UTC

[jira] Created: (VELOCITY-560) Should ExtendedProperties.convertProperties instead of ExtendedProperties.putAll

Should ExtendedProperties.convertProperties instead of ExtendedProperties.putAll
--------------------------------------------------------------------------------

                 Key: VELOCITY-560
                 URL: https://issues.apache.org/jira/browse/VELOCITY-560
             Project: Velocity
          Issue Type: Bug
          Components: Documentation
    Affects Versions: 1.5
         Environment: Any
            Reporter: Alik Eliashberg
            Priority: Minor


In the developer-guide document (http://velocity.apache.org/engine/releases/velocity-1.5/developer-guide.html), there is a section, which talks about using ExtendedProperties to initialize VelocityEngine (at the bottom of #miscellaneousdetails). 

At least for me, it didn't work as described. Instead of:
    ExtendedProperties eprops = new ExtendedProperties();

    // if you already have a Properties object do this
    eprops.putAll(props);

It should be:
       ExtendedProperties eprops = null;
       if (props==null) {
           eprops = new ExtendedProperties();
       } else {
           eprops = convertProperties(props);
       }

This is obviously very minor, but may save someone 15 minutes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


[jira] Commented: (VELOCITY-560) Should ExtendedProperties.convertProperties instead of ExtendedProperties.putAll

Posted by "Will Glass-Husain (JIRA)" <de...@velocity.apache.org>.
    [ https://issues.apache.org/jira/browse/VELOCITY-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520449 ] 

Will Glass-Husain commented on VELOCITY-560:
--------------------------------------------

Thanks for reporting this.  We'll fix the docs.

> Should ExtendedProperties.convertProperties instead of ExtendedProperties.putAll
> --------------------------------------------------------------------------------
>
>                 Key: VELOCITY-560
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-560
>             Project: Velocity
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.5
>         Environment: Any
>            Reporter: Alik Eliashberg
>            Priority: Minor
>
> In the developer-guide document (http://velocity.apache.org/engine/releases/velocity-1.5/developer-guide.html), there is a section, which talks about using ExtendedProperties to initialize VelocityEngine (at the bottom of #miscellaneousdetails). 
> At least for me, it didn't work as described. Instead of:
>     ExtendedProperties eprops = new ExtendedProperties();
>     // if you already have a Properties object do this
>     eprops.putAll(props);
> It should be:
>        ExtendedProperties eprops = null;
>        if (props==null) {
>            eprops = new ExtendedProperties();
>        } else {
>            eprops = convertProperties(props);
>        }
> This is obviously very minor, but may save someone 15 minutes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


[jira] Resolved: (VELOCITY-560) Should ExtendedProperties.convertProperties instead of ExtendedProperties.putAll

Posted by "Nathan Bubna (JIRA)" <de...@velocity.apache.org>.
     [ https://issues.apache.org/jira/browse/VELOCITY-560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nathan Bubna resolved VELOCITY-560.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.6

fixed. thanks!

> Should ExtendedProperties.convertProperties instead of ExtendedProperties.putAll
> --------------------------------------------------------------------------------
>
>                 Key: VELOCITY-560
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-560
>             Project: Velocity
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.5
>         Environment: Any
>            Reporter: Alik Eliashberg
>            Priority: Minor
>             Fix For: 1.6
>
>
> In the developer-guide document (http://velocity.apache.org/engine/releases/velocity-1.5/developer-guide.html), there is a section, which talks about using ExtendedProperties to initialize VelocityEngine (at the bottom of #miscellaneousdetails). 
> At least for me, it didn't work as described. Instead of:
>     ExtendedProperties eprops = new ExtendedProperties();
>     // if you already have a Properties object do this
>     eprops.putAll(props);
> It should be:
>        ExtendedProperties eprops = null;
>        if (props==null) {
>            eprops = new ExtendedProperties();
>        } else {
>            eprops = convertProperties(props);
>        }
> This is obviously very minor, but may save someone 15 minutes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org