[GitHub] nifi pull request: NIFI-1668 modified TestProcessorLifecycle to en...

[JPercivall <gi...@git.apache.org>]

Github user JPercivall commented on the pull request:

    https://github.com/apache/nifi/pull/324#issuecomment-221901178
  
    How will moving the building of the flow controller to the before method help the OverlappingFileLockException? The before and after methods are run immediately before and immediately after each test, so they will get executed at almost the same time as before this change. The test is failing when it's creating the state provider, which is not being used. Why not just mock it so that the state provider doesn't attempt to grab a lock on the File System? 
    
    This PR should also address the validateIdempotencyOfProcessorStartOperation method which fails many times too but in a different fashion:
    
    Tests run: 16, Failures: 1, Errors: 1, Skipped: 0, Time elapsed: 40.952 sec <<< FAILURE! - in org.apache.nifi.controller.scheduling.TestProcessorLifecycle
    validateIdempotencyOfProcessorStartOperation(org.apache.nifi.controller.scheduling.TestProcessorLifecycle)  Time elapsed: 0.162 sec  <<< FAILURE!
    java.lang.AssertionError: expected:<1> but was:<0>
    	at org.junit.Assert.fail(Assert.java:88)
    	at org.junit.Assert.failNotEquals(Assert.java:834)
    	at org.junit.Assert.assertEquals(Assert.java:645)
    	at org.junit.Assert.assertEquals(Assert.java:631)
    	at org.apache.nifi.controller.scheduling.TestProcessorLifecycle.validateIdempotencyOfProcessorStartOperation(TestProcessorLifecycle.java:178)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---