[jira] [Commented] (BAHIR-145) Flink Sink for Redis cannot perform PFADD

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BAHIR-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261975#comment-16261975 ] 

ASF GitHub Bot commented on BAHIR-145:
--------------------------------------

GitHub user phiradet opened a pull request:

    https://github.com/apache/bahir-flink/pull/23

    [BAHIR-145] Fix the JedisCluster function called when performing PFADD

    Hi All,
    
    As described in the bug report, there is a bug in the Streaming Flink connector for Redis (Cluster). The connector cannot perform PFADD correctly because of a wrong function call. Please check this fix.
    
    Best regards,
    Phiradet

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phiradet/bahir-flink BAHIR-145_flink_sink_for_redis_cannot_perform_pfadd

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bahir-flink/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit 2e20f345319e5ea6996b40f1b032678d95d3bc32
Author: Bang, Phiradet <ph...@rakuten.com>
Date:   2017-11-22T04:48:45Z

    [BAHIR-145] Fix the JedisCluster function called when performing PFADD

----


> Flink Sink for Redis cannot perform PFADD
> -----------------------------------------
>
>                 Key: BAHIR-145
>                 URL: https://issues.apache.org/jira/browse/BAHIR-145
>             Project: Bahir
>          Issue Type: Bug
>          Components: Flink Streaming Connectors
>            Reporter: O Phiradet
>
> Hi All,
> I have been using the Flink streaming connector for Redis Cluster. I have found the connector cannot perform PFADD command correctly. The root cause is a typo in the method {{pfadd}} of {{org.apache.flink.streaming.connectors.redis.common.container.RedisClusterContainer}}. The method {{pfadd}} of {{jedisCluster}} should be called, not {{set}}. 
> This bug will lead to an error when trying to retrieve value with {{PFCOUNT}} command in redis-cli, but {{GET}} works fine. 
> {code:none}
> redis 127.0.0.1:7000> PFCOUNT hll-key
> (error) WRONGTYPE Key is not a valid HyperLogLog string value.
> redis 127.0.0.1:7000> GET hll-key
> "req_1"
> {code}
> Best regards,
> Phiradet



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)