[GitHub] [nifi] simonbence commented on a change in pull request #5696: NIFI-9615 Extending capabilities of NAR provider with restraing, conflict resolution strategy and refactors to make it more flexible

[GitBox <gi...@apache.org>]

simonbence commented on a change in pull request #5696:
URL: https://github.com/apache/nifi/pull/5696#discussion_r835071109



##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework-external-resource-utils/src/main/resources/META-INF/services/org.apache.nifi.flow.resource.ExternalResourceConflictResolutionStrategy
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+org.apache.nifi.flow.resource.DoNotReplaceResolutionStrategy
+org.apache.nifi.flow.resource.ReplaceWithNewerResolutionStrategy

Review comment:
       I think there is value in the extendibility but you have a point with simplicity. We can later open the possibility to be extendible but if we go down that road now, there is no turning back.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org