You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bhaisaab <gi...@git.apache.org> on 2015/10/29 11:56:15 UTC
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1003
[4.6/master] ui/instances: show IP address of the VM on the instances page
The UI hides information regarding the IP address of the VM instance in its
detail view, the patch add the IP address column and removes the redundant
display name column.
cc @remibergsma @karuturi @wido @wilderrodrigues @NuxRo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack master-showip-instances-ui
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1003.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1003
----
commit 8bb41b5712bf696b016f05bae884708a0dfc64b4
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2015-10-29T10:51:20Z
ui/instances: show IP address of the VM on the instances page
The UI hides information regarding the IP address of the VM instance in its
detail view, the patch add the IP address column and removes the redundant
display name column.
(cherry picked from commit a1bc5a8085731195cd8409dc93f701dfdc1733ac)
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1003
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-152150034
@wido we can burn the IPv6 bridge when the time comes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-152149875
Code LGTM! Will run the tests and check the UI later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-153603199
@bhaisaab I think from the UI same value is passed for both name and display name. But if you use the API you can pass different values. The 'name' is set as hostname of the VM. But 'display name' is just a friendly name associated to the VM for easy reference.
I don't think it is a good idea to remove display name from the VM summary page. Or the fields to be displayed in the page should be made configurable. The user may choose what all fields to display in the summary page. The same can hold for the IP address as well.
Also about displaying the IP address I think @resmo raised some valid points. In advanced zone VMs in different isolated networks can have same private IP address. So not sure how it helps user/admin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by NuxRo <gi...@git.apache.org>.
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-153431622
@bhaisaab Thanks for that. The UI is indeed in need of attention.
The problem with listing the VMs is that the UI will only show a few, then as you scroll down it displays more and more. Terribly annoying!
If I would merely go on the Instances page I can use the ctrl+f in Firefox, but this will only work on the 20 or so VMs displayed.
For this reason I have a cloudmonkey script running from cronjob doing a list of all VMs together with all their information (NICs included) and spitting this in an HTML file, but it's a hack... :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-152163454
Yes I see, but the label "IP address" does not indicate that it is the first NIC's IP address :). It might make sense to change the label to be more precise in that. This is what I wanted to mention.
Regarding displayname, I don't know, but if it has a _display_ name then we should how it. Maybe we can reuse the name row and also add the displayname in a new line or at least as a html title attribute e.g. "http://www.w3schools.com/tags/att_global_title.asp
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-152162038
@resmo the IP of the first nic, not necessarily public/private. I removed displayname as adding ip address column screwed up the width/alignment issue and it's a redundant column for most people (it would be same as vm name column). I want to know if anyone wants the displayname column and for what use-cases?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-152149949
My only concern is, IPv6 is coming as well into CS, are we also going to display that address? For now this seems fine with me, but adding more columns later on makes it very wide.
But looking at the UI chance it's a very simple one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-152147077
Hi @bhaisaab
How to clean the cache in order to see the UI changes? I'm suffering a bit with the PR #996 :)
We are running the management server with Jetty.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-152165313
@resmo the field value and label is same as on the detail view's Nic tab - the default nic (or nic 1).
I'm sure there are more better ways of fixing the UI. The request to merge this PR is about - is this better than what we already have, and is it useful for most people to have this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by NuxRo <gi...@git.apache.org>.
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-153439504
That would help, I'm all for 100+ :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by NuxRo <gi...@git.apache.org>.
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-153643254
@koushik-das You are right, I did not realise the display name was missing from there.
Can't we make that table a bit wider so we can add another column or two?
It seems kind of silly to run with such a narrow design when we all have wide screens.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-152149708
Got it working, @bhaisaab!
I did a full "mvn -P developer,systemvm clean install" and started the management server. Functionality is there. :)
But good to see some more hints on how to do it.
Will test your PR today as well.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-153437575
@NuxRo I did some pagesize and latency comparisons for one of the views/APIs (see: https://github.com/apache/cloudstack/pull/751#issuecomment-135661968); I think it's a general issue with expecting to have all the resources in the list but it's not possible to get all the resources as it could the UI for long or if the network timeouts (or errors out) you'll see nothing. The default pagesize in the UI is set to 20 the last time I checked, we can easily increase this to 50 or 100 without much change in latency and UX.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-153664686
@koushik-das I understand removal of the column may not be accepted, but then the UI would look misaligned if I add another column due to strict width issues.
One way could be to make the state column compact by just showing the icons and its values (such as Running, stopped etc) as title/tooltip. I'll close this now, probably open another one in future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-153430373
@NuxRo I can check this tomorrow, I think search box simply queries listVirtualMachines API which does not support filtering by passing an IP argument.
On a related note, I'm working on some UI changes to make it slightly better on how we find information in the UI such as sorting of table (columns), some new views and navigation methods to find resources that are having issues (like finding hosts which are down in a cluster, or finding storage pools that are full visually) which might be useful. So, you can do something like list all VMs and then sort by IP and then find it, or simply search using browser's text search option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-152160447
hmm, in a advanced network setup, these IP address would be the private IPs but if it has a static NAT, the VM would also have a public IP.
For a user, it might not be obvious what kind of "IP Address" these are, public or private.
And you removed "displayname"? By mistake?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by NuxRo <gi...@git.apache.org>.
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-153427077
@bhaisaab this is awesome! Do you know if the "search box" in the Instances page will also take into account this field? Will make finding VMs easier!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-153425811
agreed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-152147799
@wilderrodrigues if you're running in dev mode, apply the UI git patch; mvn clean install -pl client; then run mgmt server. Alternatively, go to client/target/generated/ and clean the gz files: find . | grep gz$ | xargs rm ; apply the git/patch using patch tool and hard refresh chrome/firefox
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---