You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2020/05/21 13:47:33 UTC

[GitHub] [avro] dkulp commented on pull request #594: AVRO-2486 C: fwrite failure ignored, corrupting files.

dkulp commented on pull request #594:
URL: https://github.com/apache/avro/pull/594#issuecomment-632095870


   I went ahead and just did the return EIO thing.    I started doing the other idea to remove the partial writes but realized that if fwrite failed, then the ferror is set on the stream and other calls such as setting the position may not even work properly.   I didn't want to be in a position where we truncate something if the position isn't even guaranteed.  Returning EIO is certainly better than what we had. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org