You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2016/06/16 21:34:40 UTC
[jclouds/jclouds] Properly set the permissions in the ~/.ssh folder
(#968)
When writing the `~/.ssh/authorized_keys` file in a script that is being run as sudo, the file is created with the root owner, instead of the user defined by the node credentials. File ownership should be enforced to make sure the right owner is alwaays set.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/968
-- Commit Summary --
* Properly set the permissions in the ~/.ssh folder
-- File Changes --
M compute/src/main/java/org/jclouds/compute/functions/TemplateOptionsToStatement.java (2)
M compute/src/test/resources/initscript_with_java.sh (1)
M compute/src/test/resources/initscript_with_jetty.sh (1)
M compute/src/test/resources/runscript_adminUpdate.sh (1)
M scriptbuilder/src/main/java/org/jclouds/scriptbuilder/statements/login/UserAdd.java (2)
M scriptbuilder/src/main/java/org/jclouds/scriptbuilder/statements/ssh/AuthorizeRSAPublicKeys.java (11)
M scriptbuilder/src/test/java/org/jclouds/scriptbuilder/statements/login/UserAddTest.java (2)
M scriptbuilder/src/test/java/org/jclouds/scriptbuilder/statements/ssh/AuthorizeRSAPublicKeyTest.java (22)
M scriptbuilder/src/test/resources/test_adminaccess_flipped.sh (1)
M scriptbuilder/src/test/resources/test_adminaccess_params.sh (1)
M scriptbuilder/src/test/resources/test_adminaccess_params_and_fullname.sh (1)
M scriptbuilder/src/test/resources/test_adminaccess_plainuser.sh (1)
M scriptbuilder/src/test/resources/test_adminaccess_standard.sh (1)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/968.patch
https://github.com/jclouds/jclouds/pull/968.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/968
Re: [jclouds/jclouds] Properly set the permissions in the ~/.ssh
folder (#968)
Posted by Ignasi Barrera <no...@github.com>.
Closed #968.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/968#event-695366846
Re: [jclouds/jclouds] Properly set the permissions in the ~/.ssh
folder (#968)
Posted by Ignasi Barrera <no...@github.com>.
To make it right it should also consider the node credentials, as this `options.LoginUser` will only be present when someone overrides it in the options.
This requires more investigation, so I'll close it and reopen with a proper fix.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/968#issuecomment-226646388