[GitHub] [pulsar] shiv4289 opened a new pull request #4381: [Issue 4379] [Java Client] Build auth from class and params in PulsarClientImpl

[GitBox <gi...@apache.org>]

shiv4289 opened a new pull request #4381: [Issue 4379] [Java Client] Build auth from class and params in PulsarClientImpl
URL: https://github.com/apache/pulsar/pull/4381
 
 
   Fixes #4379 
   
   ### Motivation
   
   *Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
   
   ### Modifications
   In pull#4284 we added authParams and authPluginClassName to ClientConfigurationData. Though these were set the client instantiation did not build Authentication from these.
   In the same PR @Builder from lombok was added to ease building the config instances. Turns out lombok builders set to 0/null fields that are not set explicitly. This means the client instantiation crashed if numListenerThreads was not set in builder always. 
   
   *Describe the modifications you've done.*
   Construct Auth when init client from config pojo.
   Add @Builder.default to attributes in client config classes.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (yes)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: ( no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services