You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jo...@apache.org on 2022/10/08 00:06:41 UTC

[superset] branch john-bodley--fix-tables-include-database-id created (now 0846b44bd9)

This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a change to branch john-bodley--fix-tables-include-database-id
in repository https://gitbox.apache.org/repos/asf/superset.git


      at 0846b44bd9 fix: Include database filter when fetching table extra dict

This branch includes the following new commits:

     new 0846b44bd9 fix: Include database filter when fetching table extra dict

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[superset] 01/01: fix: Include database filter when fetching table extra dict

Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch john-bodley--fix-tables-include-database-id
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 0846b44bd96917c92a7e3d6241cd020c6bcedf6f
Author: John Bodley <45...@users.noreply.github.com>
AuthorDate: Fri Oct 7 17:06:34 2022 -0700

    fix: Include database filter when fetching table extra dict
---
 superset/views/core.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/superset/views/core.py b/superset/views/core.py
index 1382fbd020..60ce1edfd2 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -1198,7 +1198,10 @@ class Superset(BaseSupersetView):  # pylint: disable=too-many-public-methods
         extra_dict_by_name = {
             table.name: table.extra_dict
             for table in (
-                db.session.query(SqlaTable).filter(SqlaTable.schema == schema_parsed)
+                db.session.query(SqlaTable).filter(
+                    SqlaTable.database_id == database.id,
+                    SqlaTable.schema == schema_parsed,
+                )
             ).all()
         }