[GitHub] [hive] kgyrtkirk commented on a change in pull request #703: HIVE-21959 Clean up Concatenate and Msck DDL commands

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #703: HIVE-21959 Clean up Concatenate and Msck DDL commands
URL: https://github.com/apache/hive/pull/703#discussion_r301041322
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/MsckDesc.java
 ##########
 @@ -36,19 +34,16 @@
   private static final long serialVersionUID = 1L;
 
   private final String tableName;
-  private final ArrayList<LinkedHashMap<String, String>> partitionsSpecs;
+  private final List<Map<String, String>> partitionsSpecs;
   private final String resFile;
   private final boolean repairPartitions;
   private final boolean addPartitions;
   private final boolean dropPartitions;
 
-  public MsckDesc(String tableName, List<? extends Map<String, String>> partitionSpecs, Path resFile,
+  public MsckDesc(String tableName, List<Map<String, String>> partitionsSpecs, Path resFile,
       boolean repairPartitions, boolean addPartitions, boolean dropPartitions) {
     this.tableName = tableName;
-    this.partitionsSpecs = new ArrayList<LinkedHashMap<String, String>>(partitionSpecs.size());
 
 Review comment:
   earlier; the approach was to make a new copy

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org