You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/30 09:39:20 UTC

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP
URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400054099
 
 

 ##########
 File path: t/plugin/zipkin.t
 ##########
 @@ -126,7 +126,8 @@ done
                         "plugins": {
                             "zipkin": {
                                 "endpoint": "http://127.0.0.1:1982/mock_zipkin",
-                                "sample_ratio": 1
+                                "sample_ratio": 1,
+                                "service_name":"APISIX"
 
 Review comment:
   Add space after `:`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services