[jira] [Commented] (CB-11817) audioSettings shows as unused variable and settings are not used when configuring a recorder

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15587364#comment-15587364 ] 

ASF GitHub Bot commented on CB-11817:
-------------------------------------

Github user ghenry22 commented on the issue:

    https://github.com/apache/cordova-plugin-media/pull/116
  
    @shazron any chance this could get merged?  It's a really small change that basically just fixes an oversight in the current version, which makes recording much more efficient and stops xcode throwing warnings all over.


> audioSettings shows as unused variable and settings are not used when configuring a recorder
> --------------------------------------------------------------------------------------------
>
>                 Key: CB-11817
>                 URL: https://issues.apache.org/jira/browse/CB-11817
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Media
>    Affects Versions: 2.3.0
>         Environment: iOS
>            Reporter: Gaven Henry
>            Priority: Minor
>              Labels: easyfix
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> xcode shows up 2 warnings when building within CDVSound.m
> 1) unused variable 'audioSettings'
> 2) Null passed to a callee that requires non-null when creating an audioFile.recorder
> To resolve both of these just need to pass the autoSettings object to the audioFile.recorder function.
> This resolves both warnings and actually applies the autoSettings as expected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org