You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2023/05/16 14:06:25 UTC
[GitHub] [creadur-rat] gnodet opened a new pull request, #144: [RAT-315] Fix build with maven 3.9.x
gnodet opened a new pull request, #144:
URL: https://github.com/apache/creadur-rat/pull/144
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-rat] jochenw merged pull request #144: RAT-315: Fix build with maven 3.9.x
Posted by "jochenw (via GitHub)" <gi...@apache.org>.
jochenw merged PR #144:
URL: https://github.com/apache/creadur-rat/pull/144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-rat] gnodet commented on pull request #144: RAT-315: Fix build with maven 3.9.x
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #144:
URL: https://github.com/apache/creadur-rat/pull/144#issuecomment-1564130668
> Am I correct this fix should also resolve these Plugin validation issues reported by Maven 3.9.2 ?
>
> ```
> [WARNING] * org.apache.rat:apache-rat-plugin:0.15
> ...
> [WARNING] Plugin issue(s):
> [WARNING] * Plugin is a Maven 2.x plugin, which will be not supported in Maven 4.x
> [WARNING] * Plugin depends on plexus-container-default, which is EOL
> [WARNING]
> ```
Yes, this PR also removes the warnings caused by the rat plugin with maven 3.9.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-rat] gnodet commented on pull request #144: RAT-315: Fix build with maven 3.9.x
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #144:
URL: https://github.com/apache/creadur-rat/pull/144#issuecomment-1596931569
> @ottlinger I don't think that any of the changes proposed in the PR require either building nor running with JDK11.
Maven 3.2.5 requires JDK 6, see https://maven.apache.org/docs/history.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-rat] nielsbasjes commented on pull request #144: RAT-315: Fix build with maven 3.9.x
Posted by "nielsbasjes (via GitHub)" <gi...@apache.org>.
nielsbasjes commented on PR #144:
URL: https://github.com/apache/creadur-rat/pull/144#issuecomment-1562411464
Am I correct this fix should also resolve these Plugin validation issues reported by Maven 3.9.2 ?
```
[WARNING] * org.apache.rat:apache-rat-plugin:0.15
...
[WARNING] Plugin issue(s):
[WARNING] * Plugin is a Maven 2.x plugin, which will be not supported in Maven 4.x
[WARNING] * Plugin depends on plexus-container-default, which is EOL
[WARNING]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-rat] gnodet commented on pull request #144: RAT-315: Fix build with maven 3.9.x
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #144:
URL: https://github.com/apache/creadur-rat/pull/144#issuecomment-1559644749
> @gnodet which JDK/Mvn combination did you use? Running the branch locally yields compilation problems:
I actually had a profile which was disabling tests. So, I'll get back on that and provide an additional commit in the coming days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-rat] ottlinger commented on pull request #144: [RAT-315] Fix build with maven 3.9.x
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on PR #144:
URL: https://github.com/apache/creadur-rat/pull/144#issuecomment-1556702599
Thanks for your contributions - I assume we will have to do a release before switching gears to a more recent Maven version and drop backwards compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-rat] ottlinger commented on pull request #144: RAT-315: Fix build with maven 3.9.x
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on PR #144:
URL: https://github.com/apache/creadur-rat/pull/144#issuecomment-1559076885
@gnodet which JDK/Mvn combination did you use? Running the branch locally yields compilation problems:
```
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] RatCheckMojoTest.testIt1:135->newRatCheckMojo:57->newRatMojo:74->AbstractMojoTestCase.lookupMojo:127->AbstractMojoTestCase.lookupMojo:178->AbstractMojoTestCase.validateContainerStatus:447 » IllegalAccess class org.apache.maven.plugin.testing.AbstractMojoTestCase tried to access private field org.codehaus.plexus.PlexusTestCase.container (org.apache.maven.plugin.testing.AbstractMojoTestCase and org.codehaus.plexus.PlexusTestCase are in unnamed module of loader 'app')
[ERROR] RatCheckMojoTest.testIt2:147->newRatCheckMojo:57->newRatMojo:74->AbstractMojoTestCase.lookupMojo:127->AbstractMojoTestCase.lookupMojo:178->AbstractMojoTestCase.validateContainerStatus:447 » IllegalAccess class org.apache.maven.plugin.testing.AbstractMojoTestCase tried to access private field org.codehaus.plexus.PlexusTestCase.container (org.apache.maven.plugin.testing.AbstractMojoTestCase and org.codehaus.plexus.PlexusTestCase are in unnamed module of loader 'app')
[ERROR] RatCheckMojoTest.testIt3:187->newRatMojo:74->AbstractMojoTestCase.lookupMojo:127->AbstractMojoTestCase.lookupMojo:178->AbstractMojoTestCase.validateContainerStatus:447 » IllegalAccess class org.apache.maven.plugin.testing.AbstractMojoTestCase tried to access private field org.codehaus.plexus.PlexusTestCase.container (org.apache.maven.plugin.testing.AbstractMojoTestCase and org.codehaus.plexus.PlexusTestCase are in unnamed module of loader 'app')
[ERROR] RatCheckMojoTest.testIt4:222->newRatCheckMojo:57->newRatMojo:74->AbstractMojoTestCase.lookupMojo:127->AbstractMojoTestCase.lookupMojo:178->AbstractMojoTestCase.validateContainerStatus:447 » IllegalAccess class org.apache.maven.plugin.testing.AbstractMojoTestCase tried to access private field org.codehaus.plexus.PlexusTestCase.container (org.apache.maven.plugin.testing.AbstractMojoTestCase and org.codehaus.plexus.PlexusTestCase are in unnamed module of loader 'app')
[INFO]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-rat] ottlinger commented on pull request #144: RAT-315: Fix build with maven 3.9.x
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on PR #144:
URL: https://github.com/apache/creadur-rat/pull/144#issuecomment-1596849091
@slachiewicz This fix cannot be merged yet as it breaks the older versions of RAT.
I pressume doing a final 0.x release of RAT before changing the minor JDK versions of dependencies to JDK11 would help here (same as non-functioning upgrade of mockito due to the JDK8 restriction). I did not have time to start the discussion on the mailing list .....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-rat] kwin commented on pull request #144: RAT-315: Fix build with maven 3.9.x
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #144:
URL: https://github.com/apache/creadur-rat/pull/144#issuecomment-1596892291
@ottlinger I don't think that any of the changes proposed in the PR require either building nor running with JDK11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [creadur-rat] ottlinger commented on pull request #144: RAT-315: Fix build with maven 3.9.x
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on PR #144:
URL: https://github.com/apache/creadur-rat/pull/144#issuecomment-1597035959
Sorry to have caused a misunderstaning: as RAT relies on ancient Maven and JDK versions I thought of updating both with a new v1.x. Thus 0.x would remain with Maven2 and JDK8, while v1.x would allow to use more modern libraries and build dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org