You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/03/24 16:14:11 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #2370: Upgrade to Quarkus 1.13.0.Final
ppalaga opened a new pull request #2370:
URL: https://github.com/apache/camel-quarkus/pull/2370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #2370: Upgrade to Quarkus 1.13.0.Final
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #2370:
URL: https://github.com/apache/camel-quarkus/pull/2370#discussion_r600728979
##########
File path: integration-tests/grpc/src/main/java/org/apache/camel/quarkus/component/grpc/it/GrpcRoute.java
##########
@@ -16,22 +16,33 @@
*/
package org.apache.camel.quarkus.component.grpc.it;
+import java.util.Optional;
+
import org.apache.camel.Message;
import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.quarkus.component.grpc.it.model.PingRequest;
import org.apache.camel.quarkus.component.grpc.it.model.PongResponse;
+import org.eclipse.microprofile.config.Config;
+import org.eclipse.microprofile.config.ConfigProvider;
public class GrpcRoute extends RouteBuilder {
@Override
public void configure() throws Exception {
- from("grpc://localhost:9000/org.apache.camel.quarkus.component.grpc.it.model.PingPong?synchronous=true")
- .process(exchange -> {
- final Message message = exchange.getMessage();
- final PingRequest request = message.getBody(PingRequest.class);
- final PongResponse response = PongResponse.newBuilder().setPongName(request.getPingName() + " PONG")
- .setPongId(request.getPingId()).build();
- message.setBody(response);
- });
+ fromF("grpc://localhost:%d/org.apache.camel.quarkus.component.grpc.it.model.PingPong?synchronous=true",
Review comment:
Do we need this? IIRC the test port changes for gRPC will be a 1.14.x thing. It has not been backported to 1.13.x from what I can see.
https://github.com/quarkusio/quarkus/commit/fd713d371b10320dc8a6f9cb85fb9846255d64ac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #2370: Upgrade to Quarkus 1.13.0.Final
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #2370:
URL: https://github.com/apache/camel-quarkus/pull/2370#discussion_r600755683
##########
File path: integration-tests/grpc/src/main/java/org/apache/camel/quarkus/component/grpc/it/GrpcRoute.java
##########
@@ -16,22 +16,33 @@
*/
package org.apache.camel.quarkus.component.grpc.it;
+import java.util.Optional;
+
import org.apache.camel.Message;
import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.quarkus.component.grpc.it.model.PingRequest;
import org.apache.camel.quarkus.component.grpc.it.model.PongResponse;
+import org.eclipse.microprofile.config.Config;
+import org.eclipse.microprofile.config.ConfigProvider;
public class GrpcRoute extends RouteBuilder {
@Override
public void configure() throws Exception {
- from("grpc://localhost:9000/org.apache.camel.quarkus.component.grpc.it.model.PingPong?synchronous=true")
- .process(exchange -> {
- final Message message = exchange.getMessage();
- final PingRequest request = message.getBody(PingRequest.class);
- final PongResponse response = PongResponse.newBuilder().setPongName(request.getPingName() + " PONG")
- .setPongId(request.getPingId()).build();
- message.setBody(response);
- });
+ fromF("grpc://localhost:%d/org.apache.camel.quarkus.component.grpc.it.model.PingPong?synchronous=true",
Review comment:
Well the gRPC tests passed so I guess its fine to have this on master now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #2370: Upgrade to Quarkus 1.13.0.Final
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #2370:
URL: https://github.com/apache/camel-quarkus/pull/2370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2370: Upgrade to Quarkus 1.13.0.Final
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2370:
URL: https://github.com/apache/camel-quarkus/pull/2370#discussion_r600873819
##########
File path: integration-tests/grpc/src/main/java/org/apache/camel/quarkus/component/grpc/it/GrpcRoute.java
##########
@@ -16,22 +16,33 @@
*/
package org.apache.camel.quarkus.component.grpc.it;
+import java.util.Optional;
+
import org.apache.camel.Message;
import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.quarkus.component.grpc.it.model.PingRequest;
import org.apache.camel.quarkus.component.grpc.it.model.PongResponse;
+import org.eclipse.microprofile.config.Config;
+import org.eclipse.microprofile.config.ConfigProvider;
public class GrpcRoute extends RouteBuilder {
@Override
public void configure() throws Exception {
- from("grpc://localhost:9000/org.apache.camel.quarkus.component.grpc.it.model.PingPong?synchronous=true")
- .process(exchange -> {
- final Message message = exchange.getMessage();
- final PingRequest request = message.getBody(PingRequest.class);
- final PongResponse response = PongResponse.newBuilder().setPongName(request.getPingName() + " PONG")
- .setPongId(request.getPingId()).build();
- message.setBody(response);
- });
+ fromF("grpc://localhost:%d/org.apache.camel.quarkus.component.grpc.it.model.PingPong?synchronous=true",
Review comment:
Oh, sorry, I thought, this change was mistakenly marked as Quarkus 1.14.0.Final. But yes, let's merge as long as the test is passing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org