You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by emilianbold <gi...@git.apache.org> on 2017/09/27 13:49:28 UTC
[GitHub] incubator-netbeans pull request #19: [NETBEANS-54] Module Review openide.nod...
GitHub user emilianbold opened a pull request:
https://github.com/apache/incubator-netbeans/pull/19
[NETBEANS-54] Module Review openide.nodes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/emilianbold/incubator-netbeans emi-review-openide.nodes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-netbeans/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
----
----
---
[GitHub] incubator-netbeans pull request #19: [NETBEANS-54] Module Review openide.nod...
Posted by emilianbold <gi...@git.apache.org>.
Github user emilianbold closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/19
---
[GitHub] incubator-netbeans issue #19: [NETBEANS-54] Module Review openide.nodes
Posted by jlahoda <gi...@git.apache.org>.
Github user jlahoda commented on the issue:
https://github.com/apache/incubator-netbeans/pull/19
Sorry for now answering sooner. This is a test for "openide.nodes/src/META-INF/upgrade/org.openides.nodes.Node.hint". It is parsed by org.netbeans.modules.java.hints.declarative.test.TestParser.parse, and I believe the parser should ignore everything before the first %%TestCase.
(In principle, the tests can be also run when the module tests are run, but I doubt that is configured for the nodes module. So the way to run the test is to open it in the IDE.)
---
[GitHub] incubator-netbeans issue #19: [NETBEANS-54] Module Review openide.nodes
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/19
The change looks ok, I'd like to know how this META-INF file is used though.
---
[GitHub] incubator-netbeans issue #19: [NETBEANS-54] Module Review openide.nodes
Posted by emilianbold <gi...@git.apache.org>.
Github user emilianbold commented on the issue:
https://github.com/apache/incubator-netbeans/pull/19
Committed.
---
[GitHub] incubator-netbeans issue #19: [NETBEANS-54] Module Review openide.nodes
Posted by emilianbold <gi...@git.apache.org>.
Github user emilianbold commented on the issue:
https://github.com/apache/incubator-netbeans/pull/19
Looks like a Jackpot hints file. Not sure when it's loaded for tests only though...
---
[GitHub] incubator-netbeans issue #19: [NETBEANS-54] Module Review openide.nodes
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/19
Ok - I also did not find out the "why", but indeed the path is read from `org.netbeans.modules.java.hints.declarative.DeclarativeHintRegistry` in the `java.hints.declarative` module. The grammar suggests, that the block comment syntax is correct. Thanks for the hint.
---
[GitHub] incubator-netbeans issue #19: [NETBEANS-54] Module Review openide.nodes
Posted by jlahoda <gi...@git.apache.org>.
Github user jlahoda commented on the issue:
https://github.com/apache/incubator-netbeans/pull/19
Looks OK to me.
---