You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by co...@apache.org on 2016/09/17 06:28:06 UTC
zeppelin git commit: [HOT FIX][ZEPPELIN-1144] Fix compilation errors
in Notebook.java
Repository: zeppelin
Updated Branches:
refs/heads/master 29021896b -> c69d21f09
[HOT FIX][ZEPPELIN-1144] Fix compilation errors in Notebook.java
### What is this PR for?
After #1330 merged, the latest master build failed with below compilation errors.
```
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/ahyoungryu/Dev/zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java:[553,31] cannot find symbol
symbol: method id()
location: variable note1 of type org.apache.zeppelin.notebook.Note
[ERROR] /Users/ahyoungryu/Dev/zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java:[557,31] cannot find symbol
symbol: method id()
location: variable note2 of type org.apache.zeppelin.notebook.Note
```
### What type of PR is it?
Hot Fix
### What is the Jira issue?
### How should this be tested?
- Build the latest master branch with `mvn clean package -DskipTests` -> compilation error in `zeppelin-zengine`
- Apply this patch and build with `mvn clean package -DskipTests` -> build success
You can also check #1330 works properly.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: AhyoungRyu <fb...@hanmail.net>
Closes #1432 from AhyoungRyu/hotfix/ZEPPELIN-1144 and squashes the following commits:
6a3dbd3 [AhyoungRyu] Fix build error in Notebook.java
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/c69d21f0
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/c69d21f0
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/c69d21f0
Branch: refs/heads/master
Commit: c69d21f09b261a57021ea1b344aa84fc7d773722
Parents: 2902189
Author: AhyoungRyu <fb...@hanmail.net>
Authored: Sat Sep 17 11:42:36 2016 +0900
Committer: Damien CORNEAU <co...@gmail.com>
Committed: Sat Sep 17 15:28:00 2016 +0900
----------------------------------------------------------------------
.../src/main/java/org/apache/zeppelin/notebook/Notebook.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/c69d21f0/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java
----------------------------------------------------------------------
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java
index 38ddf46..d961ac0 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java
@@ -550,11 +550,11 @@ public class Notebook implements NoteEventListener {
}).toSortedList(new Comparator<Note>() {
@Override
public int compare(Note note1, Note note2) {
- String name1 = note1.id();
+ String name1 = note1.getId();
if (note1.getName() != null) {
name1 = note1.getName();
}
- String name2 = note2.id();
+ String name2 = note2.getId();
if (note2.getName() != null) {
name2 = note2.getName();
}