You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by aa...@apache.org on 2022/07/31 07:01:36 UTC

[rocketmq-clients] branch master updated: Fix the naming issue (#107)

This is an automated email from the ASF dual-hosted git repository.

aaronai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git


The following commit(s) were added to refs/heads/master by this push:
     new 16daf52  Fix the naming issue (#107)
16daf52 is described below

commit 16daf52b0db1399d22f608b0f445028140885c1c
Author: Aaron Ai <ya...@gmail.com>
AuthorDate: Sun Jul 31 15:01:32 2022 +0800

    Fix the naming issue (#107)
---
 .../rocketmq/client/java/impl/consumer/ProcessQueueImpl.java   | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/ProcessQueueImpl.java b/java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/ProcessQueueImpl.java
index c9b5668..ac9814f 100644
--- a/java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/ProcessQueueImpl.java
+++ b/java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/ProcessQueueImpl.java
@@ -643,7 +643,7 @@ class ProcessQueueImpl implements ProcessQueue {
                             + "consumerGroup={}, attempt={}, messageId={}, mq={}, code={}, requestId={}, endpoints={}, "
                             + "status message=[{}]", clientId, consumerGroup, attempt, messageId, mq, code, requestId,
                         endpoints, status.getMessage());
-                    ackFifoMessageLater(messageView, 1 + attempt, future0);
+                    ackMessageLater(messageView, 1 + attempt, future0);
                     return;
                 }
                 // Set result if FIFO message is acknowledged successfully.
@@ -662,15 +662,15 @@ class ProcessQueueImpl implements ProcessQueue {
             @Override
             public void onFailure(Throwable t) {
                 // Log failure and retry later.
-                LOGGER.error("Exception raised while acknowledging fifo message, clientId={}, consumerGroup={}, "
+                LOGGER.error("Exception raised while acknowledging message, clientId={}, consumerGroup={}, "
                         + "would attempt to re-ack later, attempt={}, messageId={}, mq={}, endpoints={}", clientId,
                     consumerGroup, attempt, messageId, mq, endpoints, t);
-                ackFifoMessageLater(messageView, 1 + attempt, future0);
+                ackMessageLater(messageView, 1 + attempt, future0);
             }
         }, MoreExecutors.directExecutor());
     }
 
-    private void ackFifoMessageLater(final MessageViewImpl messageView, final int attempt,
+    private void ackMessageLater(final MessageViewImpl messageView, final int attempt,
         final SettableFuture<Void> future0) {
         final MessageId messageId = messageView.getMessageId();
         final String clientId = consumer.clientId();
@@ -691,7 +691,7 @@ class ProcessQueueImpl implements ProcessQueue {
             // Should never reach here.
             LOGGER.error("[Bug] Failed to schedule message ack request, mq={}, messageId={}, clientId={}",
                 mq, messageId, clientId);
-            ackFifoMessageLater(messageView, 1 + attempt, future0);
+            ackMessageLater(messageView, 1 + attempt, future0);
         }
     }