[jira] [Comment Edited] (HBASE-17716) Formalize Scan Metric names

["Samarth Jain (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-17716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891425#comment-15891425 ] 

Samarth Jain edited comment on HBASE-17716 at 3/2/17 1:35 AM:
--------------------------------------------------------------

[~tedyu] - I see that the ServerSideScanMetrics class is marked as @InterfaceStability.Evolving. Would it be a bad thing if we break compatibility for the next minor release? Today, the way we have exposed the setCounter() api, we are letting users supply random counter names. Such random metrics wouldn't really be of use since the code would never update them. So IMHO it is better to enforce metric types via enum. If we want it for older versions of HBase, I guess we can just have constant strings defined in ScanMetrics or ServerSideScanMetrics classes.


was (Author: samarthjain):
[~tedyu] - I see that the ServerSideScanMetrics class is marked as @InterfaceStability.Evolving. Would it be a bad thing if we break compatibility for the next minor release? Today, the way we have exposed the setCounter() api, we are letting users supply random counter names. Such random metrics wouldn't really be of use since the code would never update them. So IMHO it is better to enforce metric types via enum.

> Formalize Scan Metric names
> ---------------------------
>
>                 Key: HBASE-17716
>                 URL: https://issues.apache.org/jira/browse/HBASE-17716
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: Karan Mehta
>            Assignee: Karan Mehta
>            Priority: Minor
>         Attachments: HBASE-17716.patch
>
>
> HBase provides various metrics through the API's exposed by ScanMetrics class. 
> The JIRA PHOENIX-3248 requires them to be surfaced through the Phoenix Metrics API. Currently these metrics are referred via hard-coded strings, which are not formal and can break the Phoenix API. Hence we need to refactor the code to assign enums for these metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)