You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2014/10/15 04:13:05 UTC
Review Request 26727: Hooked Isolator module to mesos containerizer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/
-----------------------------------------------------------
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
Description
-------
Hooked Isolator module to mesos containerizer.
Diffs
-----
src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2
src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
Diff: https://reviews.apache.org/r/26727/diff/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 26727: Hooked Isolator module to mesos
containerizer.
Posted by Cody Maloney <co...@mesosphere.io>.
> On Oct. 16, 2014, 2:50 a.m., Cody Maloney wrote:
> > Bad patch!
> >
> > Reviews applied: [26727]
> >
> > Failed command: ['./support/appy-review.sh', '-r', '26727']
> >
> > Error:
> > -r: ./support/appy-review.sh: No such file or directory
Ignore this. I was testing out some changes to the review checking script, broke things.
- Cody
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/#review56871
-----------------------------------------------------------
On Oct. 15, 2014, 10:08 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26727/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 10:08 p.m.)
>
>
> Review request for mesos, Ian Downes and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Hooked Isolator module to mesos containerizer.
>
>
> Diffs
> -----
>
> src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2
> src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
>
> Diff: https://reviews.apache.org/r/26727/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 26727: Hooked Isolator module to mesos
containerizer.
Posted by Cody Maloney <co...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/#review56871
-----------------------------------------------------------
Bad patch!
Reviews applied: [26727]
Failed command: ['./support/appy-review.sh', '-r', '26727']
Error:
-r: ./support/appy-review.sh: No such file or directory
- Cody Maloney
On Oct. 15, 2014, 10:08 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26727/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 10:08 p.m.)
>
>
> Review request for mesos, Ian Downes and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Hooked Isolator module to mesos containerizer.
>
>
> Diffs
> -----
>
> src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2
> src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
>
> Diff: https://reviews.apache.org/r/26727/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 26727: Allowed loading Isolator modules from module
library.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/#review57886
-----------------------------------------------------------
In testing done: I raised a question in the --isolation test patch - I don't think you exercised the code? Have you tried manually to use the --isolation flag on the slave?
- Niklas Nielsen
On Oct. 22, 2014, 12:49 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26727/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 12:49 p.m.)
>
>
> Review request for mesos, Ian Downes and Niklas Nielsen.
>
>
> Bugs: MESOS-1931
> https://issues.apache.org/jira/browse/MESOS-1931
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> If an Isolator type is not found in the default list, the code now queries ModuleManager and creates a module instance if found.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
>
> Diff: https://reviews.apache.org/r/26727/diff/
>
>
> Testing
> -------
>
> Tested it in along with --isolation flag for mesos tests.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 26727: Allowed loading Isolator modules from module
library.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/#review57914
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 22, 2014, 2:10 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26727/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 2:10 p.m.)
>
>
> Review request for mesos, Ian Downes and Niklas Nielsen.
>
>
> Bugs: MESOS-1931
> https://issues.apache.org/jira/browse/MESOS-1931
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> If an Isolator type is not found in the default list, the code now queries ModuleManager and creates a module instance if found.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
>
> Diff: https://reviews.apache.org/r/26727/diff/
>
>
> Testing
> -------
>
> Tested manually by starting a slave with the test cpu isolator:
> ./bin/mesos-slave.sh --master=127.0.0.1:5050 --modules="/home/kapil/mesos/isolator-module/modules.json" --isolation="org_apache_mesos_TestCpuIsolator"
>
>
> Also tested it in along with --isolation flag for mesos tests.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 26727: Allowed loading Isolator modules from module
library.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/
-----------------------------------------------------------
(Updated Oct. 22, 2014, 5:10 p.m.)
Review request for mesos, Ian Downes and Niklas Nielsen.
Changes
-------
Updated testing description.
Bugs: MESOS-1931
https://issues.apache.org/jira/browse/MESOS-1931
Repository: mesos-git
Description
-------
If an Isolator type is not found in the default list, the code now queries ModuleManager and creates a module instance if found.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
Diff: https://reviews.apache.org/r/26727/diff/
Testing (updated)
-------
Tested manually by starting a slave with the test cpu isolator:
./bin/mesos-slave.sh --master=127.0.0.1:5050 --modules="/home/kapil/mesos/isolator-module/modules.json" --isolation="org_apache_mesos_TestCpuIsolator"
Also tested it in along with --isolation flag for mesos tests.
Thanks,
Kapil Arya
Re: Review Request 26727: Allowed loading Isolator modules from module
library.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/
-----------------------------------------------------------
(Updated Oct. 22, 2014, 3:49 p.m.)
Review request for mesos, Ian Downes and Niklas Nielsen.
Bugs: MESOS-1931
https://issues.apache.org/jira/browse/MESOS-1931
Repository: mesos-git
Description
-------
If an Isolator type is not found in the default list, the code now queries ModuleManager and creates a module instance if found.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
Diff: https://reviews.apache.org/r/26727/diff/
Testing
-------
Tested it in along with --isolation flag for mesos tests.
Thanks,
Kapil Arya
Re: Review Request 26727: Allowed loading Isolator modules from module
library.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/
-----------------------------------------------------------
(Updated Oct. 22, 2014, 4:04 a.m.)
Review request for mesos, Ian Downes and Niklas Nielsen.
Changes
-------
Rebased diff.
Bugs: MESOS-1931
https://issues.apache.org/jira/browse/MESOS-1931
Repository: mesos-git
Description
-------
If an Isolator type is not found in the default list, the code now queries ModuleManager and creates a module instance if found.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
Diff: https://reviews.apache.org/r/26727/diff/
Testing
-------
Tested it in along with --isolation flag for mesos tests.
Thanks,
Kapil Arya
Re: Review Request 26727: Allowed loading Isolator modules from module
library.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/
-----------------------------------------------------------
(Updated Oct. 20, 2014, 11:48 p.m.)
Review request for mesos, Ian Downes and Niklas Nielsen.
Bugs: MESOS-1931
https://issues.apache.org/jira/browse/MESOS-1931
Repository: mesos-git
Description
-------
If an Isolator type is not found in the default list, the code now queries ModuleManager and creates a module instance if found.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
Diff: https://reviews.apache.org/r/26727/diff/
Testing
-------
Tested it in along with --isolation flag for mesos tests.
Thanks,
Kapil Arya
Re: Review Request 26727: Allowed loading Isolator modules from module
library.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/
-----------------------------------------------------------
(Updated Oct. 20, 2014, 9:21 p.m.)
Review request for mesos, Ian Downes and Niklas Nielsen.
Repository: mesos-git
Description
-------
If an Isolator type is not found in the default list, the code now queries ModuleManager and creates a module instance if found.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
Diff: https://reviews.apache.org/r/26727/diff/
Testing
-------
Tested it in along with --isolation flag for mesos tests.
Thanks,
Kapil Arya
Re: Review Request 26727: Allowed loading Isolator modules from module
library.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/
-----------------------------------------------------------
(Updated Oct. 18, 2014, 3:14 p.m.)
Review request for mesos, Ian Downes and Niklas Nielsen.
Changes
-------
Addressed Nik's comments.
Summary (updated)
-----------------
Allowed loading Isolator modules from module library.
Repository: mesos-git
Description (updated)
-------
If an Isolator type is not found in the default list, the code now queries ModuleManager and creates a module instance if found.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
Diff: https://reviews.apache.org/r/26727/diff/
Testing (updated)
-------
Tested it in along with --isolation flag for mesos tests.
Thanks,
Kapil Arya
Re: Review Request 26727: Hooked Isolator module to mesos
containerizer.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/#review57022
-----------------------------------------------------------
What testing did you do?
Also, let's use another term than 'hooked'
src/module/manager.hpp
<https://reviews.apache.org/r/26727/#comment97483>
I raised a question in ::create() - what happens if a user specifies a module which is not an isolator? Can you check it?
src/slave/containerizer/mesos/containerizer.cpp
<https://reviews.apache.org/r/26727/#comment97482>
Is that check enough? It is not necessarily an isolator module?
Can we templetize the contains so we can check the type/kind too?
- Niklas Nielsen
On Oct. 16, 2014, 12:22 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26727/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 12:22 p.m.)
>
>
> Review request for mesos, Ian Downes and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Hooked Isolator module to mesos containerizer.
>
>
> Diffs
> -----
>
> src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2
> src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
>
> Diff: https://reviews.apache.org/r/26727/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 26727: Hooked Isolator module to mesos
containerizer.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 3:22 p.m.)
Review request for mesos, Ian Downes and Niklas Nielsen.
Changes
-------
Updated parent.
Repository: mesos-git
Description
-------
Hooked Isolator module to mesos containerizer.
Diffs (updated)
-----
src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2
src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
Diff: https://reviews.apache.org/r/26727/diff/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 26727: Hooked Isolator module to mesos
containerizer.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/#review56831
-----------------------------------------------------------
Let's add a test too that use one of the test isolator modules to run a simple "Bring slave and master up and run a task"
- Niklas Nielsen
On Oct. 15, 2014, 3:08 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26727/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 3:08 p.m.)
>
>
> Review request for mesos, Ian Downes and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Hooked Isolator module to mesos containerizer.
>
>
> Diffs
> -----
>
> src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2
> src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
>
> Diff: https://reviews.apache.org/r/26727/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 26727: Hooked Isolator module to mesos
containerizer.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26727/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 3:08 p.m.)
Review request for mesos, Ian Downes and Niklas Nielsen.
Changes
-------
Adding Ian: Mind taking a look at this too?
Repository: mesos-git
Description
-------
Hooked Isolator module to mesos containerizer.
Diffs
-----
src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2
src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
Diff: https://reviews.apache.org/r/26727/diff/
Testing
-------
Thanks,
Kapil Arya