You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Paulo Motta (JIRA)" <ji...@apache.org> on 2017/12/08 18:03:00 UTC
[jira] [Commented] (CASSANDRA-14103) Fix potential race during
compaction strategy reload
[ https://issues.apache.org/jira/browse/CASSANDRA-14103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283939#comment-16283939 ]
Paulo Motta commented on CASSANDRA-14103:
-----------------------------------------
I thought that a simple way to fix it without messing with the locks is to not fetch the SSTables from the tracker when reloading the compaction strategies, but only when initializing the CompactionStrategyManager, and keep an sstable set in the compaction strategy manager which is used when reloading the compaction strategies.
> Fix potential race during compaction strategy reload
> ----------------------------------------------------
>
> Key: CASSANDRA-14103
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14103
> Project: Cassandra
> Issue Type: Bug
> Reporter: Paulo Motta
> Assignee: Paulo Motta
> Priority: Minor
>
> When the compaction strategies are reloaded after disk boundary changes (CASSANDRA-13948), it's possible that a recently finished SSTable is added twice to the compaction strategy: once when the compaction strategies are reloaded due to the disk boundary change ({{maybeReloadDiskBoundarie}}), and another when the {{CompactionStrategyManager}} is processing the {{SSTableAddedNotification}}.
> This should be quite unlikely because a compaction must finish as soon as the disk boundary changes, and even if it happens most compaction strategies would not be affected by it since they deduplicate sstables internally, but we should protect against such scenario.
> For more context see [this comment|https://issues.apache.org/jira/browse/CASSANDRA-13948?focusedCommentId=16280448&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280448] from Marcus.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org