Re: [PATCH] Fix for contrib/client-side/svncopy.pl.in

[Michael W Thelen <mi...@pietdepsi.com>]

kfogel@collab.net wrote:
> "Robert Reeves" <ro...@newisys.com> writes:
>>Please let me know if I am following the proper process for submitting
>>patches like this.
> 
> This is going to sound ridiculously trivial, but it actually makes a
> big difference:
> 
> Could you please attach your patch with a mime-type of "text/plain"
> instead of "application/octet-stream"?  Then it would be easy for
> people to review it right in their mailreaders, which vastly increases
> the patch's chances of being applied.

I've reattached Robert's patch as text/plain (I think!)... it's very
small.  If no one responds in a day or two, I'll file an issue for it in
the issue tracker.

-- 
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams

Re: [PATCH] Fix for contrib/client-side/svncopy.pl.in

[Michael W Thelen <mi...@pietdepsi.com>]

Julian Foad wrote:
>> You bet!  Sorry I didn't think of that.  Here's what Robert said about
>> the patch.  The log message wasn't very complete.  I've also reattached
>> the patch.
> 
> Thanks.  Hopefully someone will do something with it now.

I've gone ahead and filed it as issue #2483:
http://subversion.tigris.org/issues/show_bug.cgi?id=2483

-- 
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Fix for contrib/client-side/svncopy.pl.in

[Julian Foad <ju...@btopenworld.com>]

Michael W Thelen wrote:
> Julian Foad wrote:
> 
>>Thanks for reminding us, Michael.  The attachment as text/plain was
>>fine, but please could you re-send it with a log message, or at least
>>Robert's description of what problem this fixes if he didn't supply an
>>actual log message.  Thanks.
> 
> You bet!  Sorry I didn't think of that.  Here's what Robert said about
> the patch.  The log message wasn't very complete.  I've also reattached
> the patch.

Thanks.  Hopefully someone will do something with it now.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Fix for contrib/client-side/svncopy.pl.in

[Michael W Thelen <mi...@pietdepsi.com>]

Julian Foad wrote:
>> I've reattached Robert's patch as text/plain (I think!)... it's very
>> small.  If no one responds in a day or two, I'll file an issue for it in
>> the issue tracker.
> 
> Thanks for reminding us, Michael.  The attachment as text/plain was
> fine, but please could you re-send it with a log message, or at least
> Robert's description of what problem this fixes if he didn't supply an
> actual log message.  Thanks.

You bet!  Sorry I didn't think of that.  Here's what Robert said about
the patch.  The log message wasn't very complete.  I've also reattached
the patch.

Robert Reeves wrote:
> The current version has logic to delete the temp directory created by
> the svncopy.pl script. However, it wasn't implemented. This patch
> corrects that.
>
> [[
> Fix that enables temp dir deletion.
> ]]

-- 
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams

Re: [PATCH] Fix for contrib/client-side/svncopy.pl.in

[Julian Foad <ju...@btopenworld.com>]

Michael W Thelen wrote:
> 
> I've reattached Robert's patch as text/plain (I think!)... it's very
> small.  If no one responds in a day or two, I'll file an issue for it in
> the issue tracker.

Thanks for reminding us, Michael.  The attachment as text/plain was fine, but 
please could you re-send it with a log message, or at least Robert's 
description of what problem this fixes if he didn't supply an actual log 
message.  Thanks.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org