[GitHub] [incubator-kyuubi] dnskr commented on a diff in pull request #4004: [K8S][HELM] Add configuration files support to helm chart

[GitBox <gi...@apache.org>]

dnskr commented on code in PR #4004:
URL: https://github.com/apache/incubator-kyuubi/pull/4004#discussion_r1052603127


##########
docker/helm/templates/kyuubi-deployment.yaml:
##########
@@ -36,6 +36,8 @@ spec:
       labels:
         app.kubernetes.io/name: {{ .Chart.Name }}
         app.kubernetes.io/instance: {{ .Release.Name }}
+      annotations:
+        checksum/conf: {{ include (print $.Template.BasePath "/kyuubi-configmap.yaml") . | sha256sum }}

Review Comment:
   Yes, it's official helm recommended [Chart Development Tips and Tricks](https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments) which actually sounds funny.
   It's used in Apache Airflow [helm chart](https://github.com/apache/airflow/blob/672264b0af4874274bd130ba42a78e8e72f3d3ff/chart/templates/webserver/webserver-deployment.yaml#L79-L86) for example.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org