You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/28 11:26:30 UTC
[GitHub] [maven-dependency-plugin] kwin opened a new pull request, #257: [MDEP-674] Add m2e lifecycle metadata
kwin opened a new pull request, #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257
Use BuildContext to notify about newly generated files/folders
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MDEP) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MDEP-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MDEP-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1008066030
##########
pom.xml:
##########
@@ -247,6 +247,15 @@ under the License.
<version>${resolverVersion}</version>
<scope>provided</scope>
</dependency>
+ <!-- incremental build support (http://www.eclipse.org/m2e/documentation/m2e-making-maven-plugins-compat.html) -->
Review Comment:
yes, reported at https://github.com/eclipse-m2e/m2e-core/issues/831#issuecomment-1294846414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011702026
##########
src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java:
##########
@@ -59,6 +60,21 @@
@Component
private ArchiverManager archiverManager;
+
+ /**
+ * For m2e incremental build support
Review Comment:
Maybe `IDE build support` as this is also not only about incremental support but also about other features from the Build Support API (like notification about updates files or context-specific error messages)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] HannesWell commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
HannesWell commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1012086763
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
Review Comment:
> Imagine if every IDE ask for storing their specific files? sounds a bad design to me.
Indeed that would be bad and was the reason why I/we the M2E team reached out to the Maven devs on their mailing list (the link @kwin posted above) to establish a unified API defined/maintained by Maven that all IDEs could use. Eventually this probably would have lead to a similar Maven-defined/maintained lifecycle-mapping metadata format (which actually also could be generated from annotations see e.g. https://github.com/eclipse-m2e/m2e-core/issues/830).
But there was only negative feedback from all Maven devs about that suggestion, so each IDE has to continue to handle it their one way.
Anyway, as @mickaelistria said below we can maintain that metadata in a Eclipse M2E plug-in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011677420
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
Review Comment:
Fact is: There is no other metadata for any other IDE. Every IDE could reuse this metadata. We already have m2e metadata e.g. in https://github.com/apache/maven-resources-plugin/blob/master/src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] kwin merged pull request #257: [MDEP-674] Add IDE build support
Posted by GitBox <gi...@apache.org>.
kwin merged PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1008074703
##########
pom.xml:
##########
@@ -247,6 +247,15 @@ under the License.
<version>${resolverVersion}</version>
<scope>provided</scope>
</dependency>
+ <!-- incremental build support (http://www.eclipse.org/m2e/documentation/m2e-making-maven-plugins-compat.html) -->
+ <dependency>
+ <groupId>org.sonatype.plexus</groupId>
+ <artifactId>plexus-build-api</artifactId>
+ <version>0.0.7</version>
+ <scope>compile</scope>
+ </dependency>
Review Comment:
Compare also with the discussion at https://lists.apache.org/thread/h2gy5l7j5bv7ycbpwdjby66v8gwhzck2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] olamy commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011609215
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
Review Comment:
is there option to not store such specific IDE file here?
I don't like much this... I would be -1.
we already have a sort of specific API and now specific files.
Imagine if every IDE ask for storing their specific files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] olamy commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011609215
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
Review Comment:
is there option to not store such specific IDE file here?
I don't like much this... I would be -1.
we already have a sort of specific API and now specific files.
Imagine if every IDE ask for storing their specific files?
sounds a bad design to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] HannesWell commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
HannesWell commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1012076647
##########
src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java:
##########
@@ -59,6 +60,21 @@
@Component
private ArchiverManager archiverManager;
+
+ /**
+ * For m2e incremental build support
Review Comment:
Sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] HannesWell commented on pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
HannesWell commented on PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#issuecomment-1300976071
> @kwin @HannesWell what about adding the lifecycle mappings in https://github.com/eclipse-m2e/m2e-core/blob/master/org.eclipse.m2e.core/lifecycle-mapping-metadata.xml and not include it in the PR if this is an issue for Maven project? After all, @olamy is right and we have a way to put those mappings file somewhere else, only the BuildContext API has to be part of the plugin as far as I know.
Yes we can do that. Actually it would be natural to have all metadata in the plugin to minimize the synchronization effort, but this does only make sense if that is in a general 'Maven' format and not a IDE specific one (as said above https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1012086763)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1018133334
##########
src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java:
##########
@@ -59,6 +60,21 @@
@Component
private ArchiverManager archiverManager;
+
+ /**
+ * For m2e incremental build support
Review Comment:
Done in https://github.com/apache/maven-dependency-plugin/pull/257/commits/c34c3c754433d2a6805fd98eb60d6874222ed3dd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] cstamas commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1012099254
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
Review Comment:
> Indeed that would be bad and was the reason why I/we the M2E team reached out to the Maven devs on their mailing list (the link @kwin posted above) to establish a unified API defined/maintained by Maven that all IDEs could use. [...] But there was only negative feedback from all Maven devs about that suggestion, so each IDE has to continue to handle it their one way.
A very very strange conclusion drawn from a ML thread having his post: https://lists.apache.org/thread/044tno4lvdjvm4yv7orsqpmn3x4175c4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1018133127
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
+ <pluginExecutions>
+ <pluginExecution>
+ <pluginExecutionFilter>
+ <goals>
+ <goal>copy</goal>
+ <goal>copy-dependencies</goal>
+ <goal>properties</goal>
+ <goal>unpack</goal>
+ <goal>unpack-dependencies</goal>
+ </goals>
+ </pluginExecutionFilter>
+ <action>
+ <execute>
+ <runOnIncremental>true</runOnIncremental>
+ <runOnConfiguration>false</runOnConfiguration>
+ </execute>
+ </action>
+ </pluginExecution>
+ <pluginExecution>
+ <pluginExecutionFilter>
+ <goals>
+ <goal>analyze</goal>
+ <goal>analyze-dep-mgmt</goal>
+ <goal>analyze-only</goal>
+ <goal>analyze-report</goal>
+ <goal>analyze-duplicate</goal>
+ <goal>build-classpath</goal>
+ <goal>display-ancestors</goal>
+ <goal>get</goal>
+ <goal>go-offline</goal>
+ <goal>list</goal>
+ <goal>list-classes</goal>
+ <goal>list-repositories</goal>
+ <goal>purge-local-repository</goal>
+ <goal>resolve</goal>
+ <goal>resolve-plugins</goal>
+ <goal>sources</goal>
+ <goal>tree</goal>
+ </goals>
+ </pluginExecutionFilter>
+ <action>
+ <execute>
+ <runOnIncremental>false</runOnIncremental>
+ <runOnConfiguration>false</runOnConfiguration>
+ </execute>
Review Comment:
No longer relevant as m2e metadata has been removed from this PR, but for the record, I still want it to be run with full/clean builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on a diff in pull request #257: [MDEP-674] Add IDE build support
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1028605831
##########
src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java:
##########
@@ -59,6 +60,21 @@
@Component
private ArchiverManager archiverManager;
+
+ /**
+ * For IDE build support
+ */
+ @Component
+ private BuildContext buildContext;
+
+ /**
+ * Skip plugin execution during incremental builds (e.g. triggered from M2E).
+ *
+ * @since 3.3.1
Review Comment:
will be 3.4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1008047312
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
Review Comment:
Specific only for Eclipse ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1008067980
##########
pom.xml:
##########
@@ -247,6 +247,15 @@ under the License.
<version>${resolverVersion}</version>
<scope>provided</scope>
</dependency>
+ <!-- incremental build support (http://www.eclipse.org/m2e/documentation/m2e-making-maven-plugins-compat.html) -->
+ <dependency>
+ <groupId>org.sonatype.plexus</groupId>
+ <artifactId>plexus-build-api</artifactId>
+ <version>0.0.7</version>
+ <scope>compile</scope>
+ </dependency>
Review Comment:
Not really, it saw a new release at https://github.com/codehaus-plexus/plexus-build-api. The new GAV and packages are just not compatible with m2e yet (https://github.com/eclipse-m2e/m2e-core/issues/944).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] mickaelistria commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
mickaelistria commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011466870
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
Review Comment:
Eclipse and its derivative, such as Java edition in VSCode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1008040548
##########
pom.xml:
##########
@@ -247,6 +247,15 @@ under the License.
<version>${resolverVersion}</version>
<scope>provided</scope>
</dependency>
+ <!-- incremental build support (http://www.eclipse.org/m2e/documentation/m2e-making-maven-plugins-compat.html) -->
Review Comment:
Looks like - not up today link ...
##########
pom.xml:
##########
@@ -247,6 +247,15 @@ under the License.
<version>${resolverVersion}</version>
<scope>provided</scope>
</dependency>
+ <!-- incremental build support (http://www.eclipse.org/m2e/documentation/m2e-making-maven-plugins-compat.html) -->
+ <dependency>
+ <groupId>org.sonatype.plexus</groupId>
+ <artifactId>plexus-build-api</artifactId>
+ <version>0.0.7</version>
+ <scope>compile</scope>
+ </dependency>
Review Comment:
unmaintained dependency ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] cstamas commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1012099254
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
Review Comment:
> Indeed that would be bad and was the reason why I/we the M2E team reached out to the Maven devs on their mailing list (the link @kwin posted above) to establish a unified API defined/maintained by Maven that all IDEs could use. [...] But there was only negative feedback from all Maven devs about that suggestion, so each IDE has to continue to handle it their one way.
A very very strange conclusion drawn from a ML thread having this post: https://lists.apache.org/thread/044tno4lvdjvm4yv7orsqpmn3x4175c4
(edit: typo)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1018132317
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
Review Comment:
As there was no consensus to add m2e specific metadata I removed it now in https://github.com/apache/maven-dependency-plugin/pull/257/commits/c34c3c754433d2a6805fd98eb60d6874222ed3dd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] HannesWell commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
HannesWell commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1009881713
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
+ <pluginExecutions>
+ <pluginExecution>
+ <pluginExecutionFilter>
+ <goals>
+ <goal>copy</goal>
+ <goal>copy-dependencies</goal>
+ <goal>properties</goal>
+ <goal>unpack</goal>
+ <goal>unpack-dependencies</goal>
+ </goals>
+ </pluginExecutionFilter>
+ <action>
+ <execute>
+ <runOnIncremental>true</runOnIncremental>
+ <runOnConfiguration>false</runOnConfiguration>
+ </execute>
+ </action>
+ </pluginExecution>
+ <pluginExecution>
+ <pluginExecutionFilter>
+ <goals>
+ <goal>analyze</goal>
+ <goal>analyze-dep-mgmt</goal>
+ <goal>analyze-only</goal>
+ <goal>analyze-report</goal>
+ <goal>analyze-duplicate</goal>
+ <goal>build-classpath</goal>
+ <goal>display-ancestors</goal>
+ <goal>get</goal>
+ <goal>go-offline</goal>
+ <goal>list</goal>
+ <goal>list-classes</goal>
+ <goal>list-repositories</goal>
+ <goal>purge-local-repository</goal>
+ <goal>resolve</goal>
+ <goal>resolve-plugins</goal>
+ <goal>sources</goal>
+ <goal>tree</goal>
+ </goals>
+ </pluginExecutionFilter>
+ <action>
+ <execute>
+ <runOnIncremental>false</runOnIncremental>
+ <runOnConfiguration>false</runOnConfiguration>
+ </execute>
Review Comment:
```suggestion
<ignore/>
```
Do you want to ignore the execution? Or just want to run it on full or clean builds? Because the latter is what the current configuration is doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1008065434
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
Review Comment:
could be used by any IDE supporting incremental builds, but currently m2e is the only consumer, right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011677420
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
Review Comment:
Fact is: There is no other metadata defined for any other IDE. Every IDE could reuse this metadata. We already have m2e metadata in other Maven plugins e.g. in https://github.com/apache/maven-resources-plugin/blob/master/src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml or in https://github.com/apache/maven-enforcer/tree/master/maven-enforcer-plugin/src/main/resources/META-INF/m2e.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011677420
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
Review Comment:
Fact is: There is no other metadata for any other IDE. Every IDE could reuse this metadata. We already have m2e metadata in other Maven plugins e.g. in https://github.com/apache/maven-resources-plugin/blob/master/src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] mickaelistria commented on pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
mickaelistria commented on PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#issuecomment-1300330087
@kwin @HannesWell what about adding the lifecycle mappings in https://github.com/eclipse-m2e/m2e-core/blob/master/org.eclipse.m2e.core/lifecycle-mapping-metadata.xml and not include it in the PR if this is an issue for Maven project? After all, @olamy is right and we have a way to put those mappings file somewhere else, only the BuildContext API has to be part of the plugin as far as I know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] HannesWell commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
HannesWell commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1009883147
##########
src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java:
##########
@@ -59,6 +60,21 @@
@Component
private ArchiverManager archiverManager;
+
+ /**
+ * For m2e incremental build support
Review Comment:
Since the `BuildContext` API is not Eclipse M2E specific (even though M2E is the only user I'm aware of) I suggest to make this comment more generic.
The same applies for the comment of the `skipDuringIncrementalBuild`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1009885032
##########
src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java:
##########
@@ -59,6 +60,21 @@
@Component
private ArchiverManager archiverManager;
+
+ /**
+ * For m2e incremental build support
Review Comment:
It is mostly to not confuse it with http://takari.io/2014/03/25/incremental-build.html. Any suggestion for the naming as just `incremental build support` may be a bit too generic (as there are other incremental build APIs)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] HannesWell commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
HannesWell commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1012333852
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
Review Comment:
That's right Guillaume Nodet was not averse to the suggestion, but from the other not so positive comments I had the impression that this was not the general conclusion. However, if that was a misinterpretation from my side and the suggestion will be considered in the future, I'm glad. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] HannesWell commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
HannesWell commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1012077261
##########
pom.xml:
##########
@@ -247,6 +247,15 @@ under the License.
<version>${resolverVersion}</version>
<scope>provided</scope>
</dependency>
+ <!-- incremental build support (http://www.eclipse.org/m2e/documentation/m2e-making-maven-plugins-compat.html) -->
Review Comment:
Btw. the website is back and the link works again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] kwin commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011677420
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
Review Comment:
Fact is: There is no other metadata for any other IDE. Every IDE could reuse this metadata. We already have m2e metadata in other Maven plugins e.g. in https://github.com/apache/maven-resources-plugin/blob/master/src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml or in https://github.com/apache/maven-enforcer/tree/master/maven-enforcer-plugin/src/main/resources/META-INF/m2e.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] olamy commented on a diff in pull request #257: [MDEP-674] Add m2e lifecycle metadata
Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #257:
URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1011681071
##########
src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<lifecycleMappingMetadata>
Review Comment:
which should have never been accepted....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org