You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/01 22:57:15 UTC
[GitHub] [incubator-superset] jinhyukchang opened a new issue #10757: SQL Lab. Celery task.forget() is not supported by all backends. "NotImplementedError: backend does not implement forget."
jinhyukchang opened a new issue #10757:
URL: https://github.com/apache/incubator-superset/issues/10757
Hi,
We are using SQS on Celery and with this [PR](https://github.com/apache/incubator-superset/pull/10279), it invokes `forget()` call, but it seems SQS backend has not implemented it. From Google search, AMQP also hasn't implemented it yet.
Since, not all backend implementation has this method implemented, how about isolate this failure by wrapping with `try...except`?
```
Traceback (most recent call last):
File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/superset/views/core.py", line 2117, in _sql_json_async
task.forget()
File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/celery/result.py", line 146, in forget
self.backend.forget(self.id)
File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/celery/backends/base.py", line 463, in forget
self._forget(task_id)
File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/celery/backends/base.py", line 466, in _forget
raise NotImplementedError('backend does not implement forget.')
NotImplementedError: backend does not implement forget.
```
### Expected results
No exception when user submit query from SQL Lab.
### Actual results
Failing with message at https://github.com/apache/incubator-superset/blob/master/superset/views/core.py#L2142
#### Screenshots
If applicable, add screenshots to help explain your problem.
#### How to reproduce the bug
1. Use SQS as Celery backend
2. Submit query in SQLLab
### Environment
(please complete the following information):
- superset version: `0.37`
- python version: `3.6`
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #10757: SQL Lab. Celery task.forget() is not supported by all backends. "NotImplementedError: backend does not implement forget."
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #10757:
URL: https://github.com/apache/incubator-superset/issues/10757#issuecomment-751293964
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett closed issue #10757: SQL Lab. Celery task.forget() is not supported by all backends. "NotImplementedError: backend does not implement forget."
Posted by GitBox <gi...@apache.org>.
willbarrett closed issue #10757:
URL: https://github.com/apache/incubator-superset/issues/10757
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #10757: SQL Lab. Celery task.forget() is not supported by all backends. "NotImplementedError: backend does not implement forget."
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #10757:
URL: https://github.com/apache/incubator-superset/issues/10757#issuecomment-754272751
Closing as fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org