You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/07 09:04:13 UTC
[GitHub] [pulsar] lhotari opened a new pull request #13168: [Build] Fix modernizer-maven-plugin integration to Pulsar's build
lhotari opened a new pull request #13168:
URL: https://github.com/apache/pulsar/pull/13168
### Motivation
The current modernizer-maven-plugin integration to Pulsar's build is invalid. modernizer-maven-plugin will analyse outdated class files and this leads to obscure error messages.
### Modifications
- the phase must be set to verify
- unless this is specified, modernizer-maven-plugin will analyse outdated class files
### Additional context
- The [modernizer-maven-plugin documentation recommends using verify phase](https://github.com/gaul/modernizer-maven-plugin#configuration).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #13168: [Build] Fix modernizer-maven-plugin integration to Pulsar's build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13168:
URL: https://github.com/apache/pulsar/pull/13168#issuecomment-987712782
@lhotari:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #13168: [Build] Fix modernizer-maven-plugin integration to Pulsar's build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13168:
URL: https://github.com/apache/pulsar/pull/13168#issuecomment-987713588
@lhotari:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #13168: [Build] Fix modernizer-maven-plugin integration to Pulsar's build
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #13168:
URL: https://github.com/apache/pulsar/pull/13168#issuecomment-987712548
这是来自QQ邮箱的自动回复邮件。
您好，邮件我已经收到，我将很快回复
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #13168: [Build] Fix modernizer-maven-plugin integration to Pulsar's build
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #13168:
URL: https://github.com/apache/pulsar/pull/13168#issuecomment-987714799
@nicoloboschi @eolivelli Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #13168: [Build] Fix modernizer-maven-plugin integration to Pulsar's build
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #13168:
URL: https://github.com/apache/pulsar/pull/13168#issuecomment-987746099
> @315157973 It seems that you have automatic email responses coming all the way back to GitHub issues.
Sorry, I have shut it down
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #13168: [Build] Fix modernizer-maven-plugin integration to Pulsar's build
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #13168:
URL: https://github.com/apache/pulsar/pull/13168#issuecomment-987714252
> 这是来自QQ邮箱的自动回复邮件。 您好，邮件我已经收到，我将很快回复
@315157973 It seems that you have automatic email responses coming all the way back to GitHub issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #13168: [Build] Fix modernizer-maven-plugin integration to Pulsar's build
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #13168:
URL: https://github.com/apache/pulsar/pull/13168#issuecomment-987762260
@MarvinCai PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #13168: [Build] Fix modernizer-maven-plugin integration to Pulsar's build
Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #13168:
URL: https://github.com/apache/pulsar/pull/13168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org