You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by ay...@apache.org on 2021/06/20 11:57:52 UTC
[hadoop] 01/02: HDFS-16080. RBF: Invoking method in all locations
should break the loop after successful result (#3121). Contributed by Viraj
Jasani.
This is an automated email from the ASF dual-hosted git repository.
ayushsaxena pushed a commit to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/hadoop.git
commit ef3a2a3b3b4a6ce05b769eb879e65da5d8eb3aed
Author: Viraj Jasani <vj...@apache.org>
AuthorDate: Sun Jun 20 17:19:05 2021 +0530
HDFS-16080. RBF: Invoking method in all locations should break the loop after successful result (#3121). Contributed by Viraj Jasani.
Signed-off-by: Ayush Saxena <ay...@apache.org>
---
.../hdfs/server/federation/router/RouterRpcClient.java | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
index ef255d9..aeb6461 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
+++ b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
@@ -1018,25 +1018,17 @@ public class RouterRpcClient {
* Invoke method in all locations and return success if any succeeds.
*
* @param <T> The type of the remote location.
- * @param <R> The type of the remote method return.
* @param locations List of remote locations to call concurrently.
* @param method The remote method and parameters to invoke.
* @return If the call succeeds in any location.
* @throws IOException If any of the calls return an exception.
*/
- public <T extends RemoteLocationContext, R> boolean invokeAll(
+ public <T extends RemoteLocationContext> boolean invokeAll(
final Collection<T> locations, final RemoteMethod method)
- throws IOException {
- boolean anyResult = false;
+ throws IOException {
Map<T, Boolean> results =
invokeConcurrent(locations, method, false, false, Boolean.class);
- for (Boolean value : results.values()) {
- boolean result = value.booleanValue();
- if (result) {
- anyResult = true;
- }
- }
- return anyResult;
+ return results.containsValue(true);
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org